Closed Bug 619220 Opened 15 years ago Closed 15 years ago

Honor the first <base href> in doc for base URL and the first <base target> in the doc for the default browsing context target

Categories

(Core :: DOM: Core & HTML, defect, P1)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b10
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: hsivonen, Assigned: bzbarsky)

References

(Depends on 1 open bug)

Details

(Whiteboard: [softblocker])

Attachments

(2 files)

Allow <base> elements that are not direct children of the <head>.
12.04 KB, patch
sicking
: review+
sicking
: approval2.0+
Details | Diff | Splinter Review
Fix the speculative loading code to agree with the DOM code
1.51 KB, patch
sicking
: review+
sicking
: approval2.0+
Details | Diff | Splinter Review
The HTML5 spec changed to honor the first <base href> in the doc and the first <base target> in the doc instead of honoring the first one in <head> only. See http://lists.w3.org/Archives/Public/public-html/2010Dec/0060.html http://html5.org/tools/web-apps-tracker?from=5710&to=5711 This should be implemented in Gecko in order to resolve bug 593807 and bug 592880.
blocking2.0: --- → ?
Assignee: nobody → bzbarsky
Priority: -- → P1
Whiteboard: [need review]
At http://mxr.mozilla.org/mozilla-central/source/parser/html/nsHtml5TreeBuilderCppSupplement.h#152 the part 152 } else if (nsHtml5Atoms::base == aName && 153 (mode == NS_HTML5TREE_BUILDER_IN_HEAD || 154 mode == NS_HTML5TREE_BUILDER_AFTER_HEAD)) { needs to become 152 } else if (nsHtml5Atoms::base == aName) { to make the preloads agree with the DOM side.
Attachment #500823 - Flags: review?(jonas)
Whiteboard: [need review] → [need approval]
Attachment #499427 - Flags: approval2.0?
Attachment #500823 - Flags: approval2.0?
Whiteboard: [need approval] → [need landing]
blocking2.0: ? → final+
Whiteboard: [need landing] → [need landing][softblocker]
Pushed the changes in this bug: http://hg.mozilla.org/mozilla-central/rev/17aa7cd8fe48 http://hg.mozilla.org/mozilla-central/rev/11b1e456a331 and then an orange fix: http://hg.mozilla.org/mozilla-central/rev/1c5a0e0b5d0b
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [need landing][softblocker] → [softblocker]
Target Milestone: --- → mozilla2.0b10
Depends on: 627361
Depends on: 640499
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: