619230 - leak test build: "WARNING: The category has no corresponding type!: file ../../../dom/base/nsScriptNameSpaceManager.cpp, line 690"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1292348163.1292349259.30746.gz&fulltext=1
Linux mozilla-central leak test build on 2010/12/14 09:36:03
{
WARNING: The category has no corresponding type!: file ../../../dom/base/nsScriptNameSpaceManager.cpp, line 690
}

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1292369774.1292372380.30342.gz&fulltext=1
Linux comm-central-trunk leak test build on 2010/12/14 15:36:14
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1292367545.1292368633.14869.gz&fulltext=1
OS X 10.6 comm-central-trunk leak test build on 2010/12/14 14:59:05
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1292366108.1292371067.24907.gz&fulltext=1
WINNT 5.2 comm-central-trunk leak test build on 2010/12/14 14:35:08
too.

Comment 1

[Peter Van der Beken [:peterv]]

Mounir: Why do we even have this warning? As far as I can see that observer will get called for new entries for any category, so it's not an error if we are in AddCategoryEntryToHash with an unknown category. In my trunk build I see a ton of warnings for:

The category 'Gecko-Content-Viewers' has no corresponding type!

I think you should remove the warning and just return NS_OK in AddCategoryEntryToHash if the category is not one we care about. You should also move the category check to be the first thing we do in AddCategoryEntryToHash.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch v1 [Checked in: See comment 5]

Indeed. My bad :(

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 507464 [details] [diff] [review]
Patch v1
[Checked in: See comment 5]

>+  } else {
>+    return NS_OK;
>+  }

Nit: It may be worth documenting this case in the corresponding .h file.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 507464 [details] [diff] [review]
Patch v1
[Checked in: See comment 5]

Nit: And remove '#include "nsPrintfCString.h"', to fully revert bug   	    621515.

Comment 5

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/7f80cd5abf47