619272 - Intermittent failure in layout/reftests/css-import/290018-1.html | image comparison (==)

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[(no longer active)]

Attachment: Reftest failure log

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1292383308.1292386591.27867.gz
Rev3 WINNT 6.1 mozilla-central debug test reftest on 2010/12/14 19:21:48

Reftest log attached.

Jonathan, do you think this is an instance of the bug you showed me yesterday?  (can't find its bug number right now)

Comment 1

[Jonathan Kew [:jfkthame]]

Yes, looks like it probably is. There's one faint AA pixel from the crossbar of the "t" that projects to the left of the origin of the text, and we're painting (or erasing, or clipping, or something) using a bounding box that doesn't include this pixel.

The Windows version of the bug about this is bug 475968 (the Mac OS X equivalent is bug 476927).

Not sure why this would be intermittent - perhaps a timing issue in relation to loading the stylesheet and (re)painting in response to the content and style changes that the script triggers?

Comment 2

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1292373253.1292376708.16038.gz
Rev3 WINNT 6.1 mozilla-central debug test reftest on 2010/12/14 16:34:13
s: talos-r3-w7-018

You actually filed it on the second of two failures in a row (where the first was the second test run on the same cset, so not related to code, and a retest on the one you filed on went green, so at least it really is intermittent).

Comment 3

[Legacy TBPL/Treeherder Robot]

philringnalda%gmail.com
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1292393739.1292397086.8151.gz
Rev3 WINNT 6.1 mozilla-central debug test reftest on 2010/12/14 22:15:39

s: talos-r3-w7-036
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central_win7-debug_test-reftest/build/reftest/tests/layout/reftests/css-import/290018-1.html | image comparison (==)
PROCESS-CRASH | Main app process exited normally | application crashed (minidump found)
Thread 0 (crashed)
PROCESS-CRASH | Main app process exited normally | application crashed (minidump found)
Thread 0 (crashed)
PROCESS-CRASH | Main app process exited normally | application crashed (minidump found)
Thread 0 (crashed)
PROCESS-CRASH | Main app process exited normally | application crashed (minidump found)
Thread 0 (crashed)

Comment 4

[Legacy TBPL/Treeherder Robot]

mounir.lamouri%gmail.com
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1292393739.1292397086.8151.gz
Rev3 WINNT 6.1 mozilla-central debug test reftest on 2010/12/14 22:15:39

s: talos-r3-w7-036
REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central_win7-debug_test-reftest/build/reftest/tests/layout/reftests/css-import/290018-1.html | image comparison (==)
PROCESS-CRASH | Main app process exited normally | application crashed (minidump found)
Thread 0 (crashed)
PROCESS-CRASH | Main app process exited normally | application crashed (minidump found)
Thread 0 (crashed)
PROCESS-CRASH | Main app process exited normally | application crashed (minidump found)
Thread 0 (crashed)
PROCESS-CRASH | Main app process exited normally | application crashed (minidump found)
Thread 0 (crashed)

Comment 5

[Phil Ringnalda (:philor)]

And that one that we double-starred? That's the third one on the same cset, which has now failed two of three.

Comment 6

[Phil Ringnalda (:philor)]

Blocking reopening the tree, until someone overrules me.

The story goes like this:

http://hg.mozilla.org/mozilla-central/rev/abe884259481, a JS patch that certainly shouldn't affect text rendering only on Win7, landed on TraceMonkey, where this isn't happening, and then a short time later on mozilla-central. Then releng landed a build-directory shortening patch and some other stuff, which broke the tree. Two builds wound up being retriggered on abe884259481, and one reftest passed and the other was the first failure of this.

http://hg.mozilla.org/mozilla-central/rev/f11f7ed625ba, the version bump after tagging for b8, landed, and that was the second failure of this. I got a couple more reftest runs triggered on it, and the first was green, but the second was the third failure of this.

So on pushes that should have had absolutely nothing to do with this, it's failed 3 of 5 times on 3 different slaves. Something's really weird.

Comment 7

[(no longer active)]

I also saw this locally with a seemingly unrelated change.  Adding a manual flush in the test before removing reftest-wait fixed things for me.  Is this something which should be done with this test too?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: workaround

We should land this. It ought to fix the bug.

It's weird for those patches to cause it to fail, but whatever, we understand the bug. Let's work around it until we land the real fixes.

Comment 9

[Jonathan Kew [:jfkthame]]

Attachment: patch, add padding to the text to avoid potential clipping of antialiasing pixel

I think we can fix this failure by adding a bit of padding to the text, so that the antialiasing pixel doesn't project outside the frame.

(This is just a band-aid for the failing test; the real issue is bug 475968, but that patch will need careful evaluation and testing as it has potentially far-reaching effects.)

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 497748 [details] [diff] [review]
patch, add padding to the text to avoid potential clipping of antialiasing pixel

This works too.

PS, go to sleep.

Comment 11

[(no longer active)]

I'll land this, but I probably won't be around long enough to watch the tree...

Comment 12

[(no longer active)]

Jonathan was faster!

http://hg.mozilla.org/mozilla-central/rev/90b17476216d