continuing is always false in nsFind::Find

RESOLVED FIXED in mozilla5

Status

()

--
enhancement
RESOLVED FIXED
8 years ago
5 months ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
mozilla5
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
i haven't done the cvs archeology on this, but...
(Assignee)

Comment 1

8 years ago
Created attachment 497745 [details] [diff] [review]
remove it
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #497745 - Flags: review?(neil)
Attachment #497745 - Flags: approval2.0?
(In reply to comment #0)
> i haven't done the cvs archeology on this, but...
Bug 123087 apparently introduced this unused variable.
Comment on attachment 497745 [details] [diff] [review]
remove it

>-    // If we were continuing, then this ends our search.
>-    if (continuing) {
>-      ResetAll();
>-      return NS_OK;
>-    }
> 
Nit: remove the blank line too.
Attachment #497745 - Flags: review?(neil) → review+
Attachment #497745 - Flags: approval2.0? → approval2.0-

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/eec499aeddf3
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.