Closed
Bug 619282
Opened 14 years ago
Closed 14 years ago
continuing is always false in nsFind::Find
Categories
(Core :: Find Backend, enhancement)
Core
Find Backend
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file)
|
1.80 KB,
patch
|
neil
:
review+
beltzner
:
approval2.0-
|
Details | Diff | Splinter Review |
i haven't done the cvs archeology on this, but...
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #497745 -
Flags: review?(neil)
Attachment #497745 -
Flags: approval2.0?
|
||
Comment 2•14 years ago
|
||
(In reply to comment #0) > i haven't done the cvs archeology on this, but... Bug 123087 apparently introduced this unused variable.
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 497745 [details] [diff] [review] remove it >- // If we were continuing, then this ends our search. >- if (continuing) { >- ResetAll(); >- return NS_OK; >- } > Nit: remove the blank line too.
Attachment #497745 -
Flags: review?(neil) → review+
|
||
Updated•14 years ago
|
Attachment #497745 -
Flags: approval2.0? → approval2.0-
|
||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/eec499aeddf3
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•