619366 - crash [@ nsFolderCompactState::FinishCompact()]

Status: RESOLVED WORKSFORME

(MailNews Core :: Backend, defect)

Description

[Wayne Mery (:wsmwk)]

crash [@ nsFolderCompactState::FinishCompact()]

not a new crash in 3.1.7

bp-075b2624-f68e-4153-b548-004272101215
EXCEPTION_ACCESS_VIOLATION_READ
0x0
0	thunderbird.exe	nsFolderCompactState::FinishCompact	mailnews/base/src/nsMsgFolderCompactor.cpp:417
1	thunderbird.exe	nsFolderCompactState::OnStopRequest	mailnews/base/src/nsMsgFolderCompactor.cpp:619
2	thunderbird.exe	nsMsgProtocol::OnStopRequest	mailnews/base/util/nsMsgProtocol.cpp:401
3	thunderbird.exe	nsMailboxProtocol::OnStopRequest	mailnews/local/src/nsMailboxProtocol.cpp:381
4	thunderbird.exe	nsInputStreamPump::OnStateStop	netwerk/base/src/nsInputStreamPump.cpp:578
5	thunderbird.exe	nsInputStreamPump::OnInputStreamReady	netwerk/base/src/nsInputStreamPump.cpp:403

Comment 1

[timeless]

368 nsresult nsFolderCompactState::StartCompacting()
414 GetSummaryFileLocation(folderPath, getter_AddRefs(summaryFile));
416 nsCString leafName;
417 summaryFile->GetNativeLeafName(leafName); 

summaryFile is null

Comment 2

[timeless]

i think i spent time looking at this, i concluded that i couldn't figure out what to do when this happened. so i'm punting :(

Comment 3

[Wayne Mery (:wsmwk)]

bienvenu and rkent receiving timeless' punt?

(In reply to comment #1)
> 368 nsresult nsFolderCompactState::StartCompacting()
> 414 GetSummaryFileLocation(folderPath, getter_AddRefs(summaryFile));
> 416 nsCString leafName;
> 417 summaryFile->GetNativeLeafName(leafName); 
> 
> summaryFile is null
(In reply to comment #2)
> i think i spent time looking at this, i concluded that i couldn't figure out
> what to do when this happened. so i'm punting :(


v5 stack bp-d72caac2-e9cb-4ea0-b08f-3f1b62110719
0	xul.dll	nsFolderCompactState::FinishCompact	mailnews/base/src/nsMsgFolderCompactor.cpp:418
1	xul.dll	nsFolderCompactState::OnStopRequest	mailnews/base/src/nsMsgFolderCompactor.cpp:620
2	xul.dll	nsMsgProtocol::OnStopRequest	mailnews/base/util/nsMsgProtocol.cpp:429
3	xul.dll	nsMailboxProtocol::OnStopRequest	mailnews/local/src/nsMailboxProtocol.cpp:381 


nsFolderCompactState::FinishCompact is the second most common sig for Compact. All of these have roughly the same number of crahes 
1. nsFolderCompactState::EndCopy(nsISupports*, unsigned int)
2. nsFolderCompactState::FinishCompact()
3. arena_dalloc_small | arena_dalloc | free | nsFolderCompactState::`vector 3. deleting destructor''(unsigned int)
4. arena_dalloc_small | arena_dalloc | free | nsFolderCompactState::`scalar deleting destructor''(unsigned int)

Comment 4

[Wayne Mery (:wsmwk)]

bienvenu, do we need more than the stack?

still a strong crash rate.
bp-294c20bb-b1fe-4342-98e8-b4d4a2120223

Comment 5

[David :Bienvenu]

summaryFile is pretty obviously null, so we can avoid the crash with a null check. I'm not sure why it would ever be null, and since we don't have steps to reproduce this, knowing if we've handled the error correctly is going to be tricky.

Comment 6

[Wayne Mery (:wsmwk)]

WFM? Fixed?
gone starting in version 17.0, i.e. last crashes are in 16.0.2, and I don't see that the signature morphed into something else. Odd. 

Could Bug 674742 have had an impact? If not, what did?   

Crash-stats not helpful determining when crashes stopped because no crashes in 17 alphas and betas leading up to version 17 release.  Perhaps I can do a better search after socorro version 40 - it should permit searching alpha and beta channels regardless of version.

Comment 7

[Wayne Mery (:wsmwk)]

Still no crashes for current versions