619595 - Create threaded benchmark using existing benchmarks

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Paul Biggar]

By creating a harness which runs each kraken/v8/sunspider benchmark is a separate thread, we should be able to exercise the threading code, which isn't otherwise tested that well. This would be useful to julian to run helgrind on.

Comment 1

[Andreas Gal :gal]

You mean worker threads?

Comment 2

[Paul Biggar]

Yes, though it occurred to me to also do a pseudo-multi-single-threaded version (using events?) for GC testing.

Comment 3

[Paul Biggar]

Attachment: Web worker implementation

Julian, how does this work for you? Run:

  js workers.js

Comment 4

[Paul Biggar]

Attachment: Add --helgrind option to jit-test.py

This integrates the webworkers test with jit-test. This means you can use the standard flags like --jitflags, -s, -o, and the pattern matching syntax.

Julian, if this is useful to you, I can get review and get this into the tree.

Julian, have you a suppression file (or the helgrind version thereof) that can go with this?

Comment 5

[Julian Seward [:jseward]]

(In reply to comment #4)
> Created attachment 499236 [details] [diff] [review]
> Add --helgrind option to jit-test.py

I can't make this work.  It appears to require the existence of
js/src/jit-test/lib/workers.js, which is absent.

Comment 6

[Paul Biggar]

Attachment: Add --helgrind option to jit-test.py

My bad. I had renamed the files, but I hadn't noticed because helgrind doesn't even get that far on my system.

Comment 7

[Alon Zakai (:azakai)]

+1 for benchmarking worker threads, there do seem to be some cases with perf issues, for example bug 621581, bug 653967, and bug 600443.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.