Closed
Bug 619653
Opened 14 years ago
Closed 6 years ago
Harmonize styling of about: diagnostic pages
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: at.light, Unassigned)
References
Details
Attachments
(2 files, 1 obsolete file)
37.59 KB,
patch
|
Details | Diff | Splinter Review | |
2.67 KB,
patch
|
Details | Diff | Splinter Review |
In bug 594996 comment 4, beltzner suggested the harmonization of about: pages that deal with internals/troubleshooting. This patch does that, making them all use aboutSupport.css. The affected pages are: * about:crashes * about:cache * about:cache-entry * about:memory * about:buildconfig about:startup needs no changes, and about:plugins is covered in bug 619652.
Attachment #498084 -
Flags: review?
Comment 1•14 years ago
|
||
(In reply to comment #0) > making them all use aboutSupport.css. This doesn't make sense. You should add a new file with a name that reflects the actual use.
Reporter | ||
Comment 2•14 years ago
|
||
(In reply to comment #1) > This doesn't make sense. I was modelling this after about:startup (bug 593743), which does in fact apply aboutSupport.css. I will add a patch for about:startup when it re-lands. I will post a revised patch which uses the filename "chrome://global/skin/diagnostics.css" once I have fixed some tree issues.
Reporter | ||
Updated•14 years ago
|
Attachment #498084 -
Flags: review?
Reporter | ||
Comment 3•14 years ago
|
||
Split into two patches, due to weirdness.
Attachment #498084 -
Attachment is obsolete: true
Attachment #498285 -
Flags: review?
Reporter | ||
Comment 4•14 years ago
|
||
Attachment #498286 -
Flags: review?
Comment 5•14 years ago
|
||
Alan, you need to pick a reviewer when setting the review? flag (Dao would be the natural choice here, I think)
Comment 6•14 years ago
|
||
Comment on attachment 498285 [details] [diff] [review] Patch part 1, v.2 >+#define APPEND_ROW_CODE(label, value) \ This is unused. >+ .report-date, .report-time { nit: generally break the line after the comma
Reporter | ||
Updated•14 years ago
|
Attachment #498285 -
Flags: review?
Reporter | ||
Comment 7•14 years ago
|
||
Thanks for the review, Dão. I will post updated patches once I've fixed the problem I'm having with the part 2 patch (attachment 498286 [details] [diff] [review]). It won't apply without rejections. Does it work for others?
Reporter | ||
Comment 8•13 years ago
|
||
I have no time to work on this right now.
Assignee: at.light → nobody
Status: ASSIGNED → NEW
Comment 9•13 years ago
|
||
Comment on attachment 498286 [details] [diff] [review] Patch part 2, v.2 Clearing review request per last comment.
Attachment #498286 -
Flags: review?
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•