If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

unused variable dataSize in nsDiskCacheStreamIO::FlushBufferToFile

RESOLVED FIXED in mozilla5

Status

()

Core
Networking: Cache
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
mozilla5
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
netwerk/cache/nsDiskCacheStreams.cpp:
 In member function ‘nsresult nsDiskCacheStreamIO::FlushBufferToFile()’:
735: warning: unused variable ‘dataSize’
(Assignee)

Comment 1

7 years ago
Created attachment 498111 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498111 - Flags: review?
Attachment #498111 - Flags: approval2.0?
(Assignee)

Updated

7 years ago
Attachment #498111 - Flags: review? → review?(jduell.mcbugs)
Comment on attachment 498111 [details] [diff] [review]
patch

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Attachment #498111 - Flags: approval2.0? → approval2.0-
Comment on attachment 498111 [details] [diff] [review]
patch

This will get fixed as part of bug 592422.  Meanwhile we can live with the warning, given the new overhead of landing on m-c. (i.e I don't want to bother drivers with a patch just for a warning).
Attachment #498111 - Flags: review?(jduell.mcbugs) → review-
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
Not sure what overhead this is about.
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: WONTFIX → ---
http://hg.mozilla.org/projects/cedar/rev/09f0f34dcd8a
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2
http://hg.mozilla.org/mozilla-central/rev/09f0f34dcd8a
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
You need to log in before you can comment on or make changes to this bug.