Closed Bug 619685 Opened 9 years ago Closed 9 years ago

unused variable dataSize in nsDiskCacheStreamIO::FlushBufferToFile

Categories

(Core :: Networking: Cache, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file)

775 bytes, patch
jduell.mcbugs
: review-
Details | Diff | Splinter Review
netwerk/cache/nsDiskCacheStreams.cpp:
 In member function ‘nsresult nsDiskCacheStreamIO::FlushBufferToFile()’:
735: warning: unused variable ‘dataSize’
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498111 - Flags: review?
Attachment #498111 - Flags: approval2.0?
Attachment #498111 - Flags: review? → review?(jduell.mcbugs)
Comment on attachment 498111 [details] [diff] [review]
patch

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Attachment #498111 - Flags: approval2.0? → approval2.0-
Comment on attachment 498111 [details] [diff] [review]
patch

This will get fixed as part of bug 592422.  Meanwhile we can live with the warning, given the new overhead of landing on m-c. (i.e I don't want to bother drivers with a patch just for a warning).
Attachment #498111 - Flags: review?(jduell.mcbugs) → review-
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Not sure what overhead this is about.
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: WONTFIX → ---
http://hg.mozilla.org/projects/cedar/rev/09f0f34dcd8a
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2
http://hg.mozilla.org/mozilla-central/rev/09f0f34dcd8a
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
You need to log in before you can comment on or make changes to this bug.