Closed
Bug 619685
Opened 14 years ago
Closed 13 years ago
unused variable dataSize in nsDiskCacheStreamIO::FlushBufferToFile
Categories
(Core :: Networking: Cache, defect)
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: timeless, Assigned: timeless)
References
Details
Attachments
(1 file)
775 bytes,
patch
|
jduell.mcbugs
:
review-
jst
:
approval2.0-
|
Details | Diff | Splinter Review |
netwerk/cache/nsDiskCacheStreams.cpp: In member function ‘nsresult nsDiskCacheStreamIO::FlushBufferToFile()’: 735: warning: unused variable ‘dataSize’
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498111 -
Flags: review?
Attachment #498111 -
Flags: approval2.0?
Attachment #498111 -
Flags: review? → review?(jduell.mcbugs)
Comment 2•13 years ago
|
||
Comment on attachment 498111 [details] [diff] [review] patch Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Attachment #498111 -
Flags: approval2.0? → approval2.0-
Comment 3•13 years ago
|
||
Comment on attachment 498111 [details] [diff] [review] patch This will get fixed as part of bug 592422. Meanwhile we can live with the warning, given the new overhead of landing on m-c. (i.e I don't want to bother drivers with a patch just for a warning).
Attachment #498111 -
Flags: review?(jduell.mcbugs) → review-
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Comment 4•13 years ago
|
||
Not sure what overhead this is about.
Comment 5•13 years ago
|
||
http://hg.mozilla.org/projects/cedar/rev/09f0f34dcd8a
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/09f0f34dcd8a
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
You need to log in
before you can comment on or make changes to this bug.
Description
•