619690 - [compare-locales] add option to clobber mergedir

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect)

Description

[Axel Hecht [:Pike]]

When adding l10n-merge, I intentionally didn't add an option to clear the mergedir, because I wouldn't want to prune a complete directory with a command that people could mistype and kill their OS or something.

It might make sense to add a scary option, and I guess we should be able to not prune the whole mergedir, but just the subdirs that are picked up as compare-locales runs. That way, it'd be less scary, as your OS is unlikely to be in browser or toolkit.

Should make automation easier, in particular.

Comment 1

[Axel Hecht [:Pike]]

Any preference on releng's side on what to do on errors during the removal?

I'm leaning towards an exit(2) to distinguish from the exit(1) for the non-merging missing strings case?

Comment 2

[Axel Hecht [:Pike]]

I've got a patch now. It's doing an exit(2) for all OS and IOErrors, which is probably the right thing to do. It doesn't catch other exceptions, though.

It's based on the current RELEASE_AUTOMATION tag, which I'll then merge to head. That way, we can take this change without needing to think about the l10n-merge changes yet.

Comment 3

[Axel Hecht [:Pike]]

Attachment: clobber merge dirs per module, exit(2) on failure.

Comment 4

[Armen [:armenzg]]

Comment on attachment 500036 [details] [diff] [review]
clobber merge dirs per module, exit(2) on failure.

The patch looks good to me.

We can file later a bug when we want to actually use it.

Comment 5

[Axel Hecht [:Pike]]

http://hg.mozilla.org/l10n/compare-locales/rev/58d50338f68c, FIXED.