Closed
Bug 619730
Opened 14 years ago
Closed 14 years ago
Support arbitrary blocklist items passed through the observer service
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b9
People
(Reporter: mossop, Assigned: mossop)
References
Details
Attachments
(1 file, 1 obsolete file)
5.85 KB,
patch
|
robert.strong.bugs
:
review+
mossop
:
approval2.0+
|
Details | Diff | Splinter Review |
The GFX team want to be able to receive a snippet of the blocklist when we download an update so we're going to be including a gfxItems element in the blocklist. We don't need to do any parsing of it and just pass it to them through the observer service. It probably makes sense to handle this in a simplistic fashion and just pass all elements that we don't recognise through the observer service through the topic blocklist-data-<tagname> so GFX would register for blocklist-data-gfxItems.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → dtownsend
Assignee | ||
Comment 1•14 years ago
|
||
This implements the change sending out the unknown items to the observer service and includes basic tests that that happens
Attachment #498195 -
Flags: review?(robert.bugzilla)
Assignee | ||
Updated•14 years ago
|
Whiteboard: [has patch][needs review rs]
Assignee | ||
Comment 2•14 years ago
|
||
Comment on attachment 498195 [details] [diff] [review] patch rev 1 Totally not the right patch
Attachment #498195 -
Attachment is obsolete: true
Attachment #498195 -
Flags: review?(robert.bugzilla)
Assignee | ||
Comment 3•14 years ago
|
||
Attachment #498197 -
Flags: review?(robert.bugzilla)
Comment 4•14 years ago
|
||
Comment on attachment 498197 [details] [diff] [review] patch rev 1 Looks straightforward enough
Attachment #498197 -
Flags: review?(robert.bugzilla) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #498197 -
Flags: approval2.0+
Assignee | ||
Comment 5•14 years ago
|
||
Landed: http://hg.mozilla.org/mozilla-central/rev/8777141fa716
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch][needs review rs]
Target Milestone: --- → mozilla2.0b9
Comment 6•13 years ago
|
||
Marking as verified fixed based on the automated test and no test failure since the check-in.
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: x86 → All
You need to log in
before you can comment on or make changes to this bug.
Description
•