FrameState::init leaks cursor when reifier.init() fails

RESOLVED FIXED in mozilla6

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({coverity, mlk})

Trunk
mozilla6
x86
Windows 7
coverity, mlk
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-cedar, URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
69 FrameState::init()
70 {
89     uint8 *cursor = (uint8 *)cx->calloc(totalBytes);
90     if (!cursor)
91         return false;
92 
93 #if defined JS_NUNBOX32
94     if (!reifier.init(nentries))
this leaks cursor:
95         return false;
(Assignee)

Comment 1

6 years ago
Created attachment 498295 [details] [diff] [review]
reorder
Assignee: general → timeless
Status: NEW → ASSIGNED
Attachment #498295 - Flags: review?(jorendorff)
Comment on attachment 498295 [details] [diff] [review]
reorder

Review of attachment 498295 [details] [diff] [review]:

r=me
Attachment #498295 - Flags: review?(jorendorff) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/projects/cedar/rev/7dcb9b3fa354
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla6
http://hg.mozilla.org/mozilla-central/rev/7dcb9b3fa354
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.