Closed
Bug 619802
Opened 15 years ago
Closed 15 years ago
nsLocaleService::nsLocaleService leaks resultLocale when posixConverter->GetXPLocale() fails
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, memory-leak)
Attachments
(1 file)
|
2.11 KB,
patch
|
smontagu
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
148 nsLocaleService::nsLocaleService(void)
187 nsLocale* resultLocale;
188 int i;
189
190 resultLocale = new nsLocale();
191 if ( resultLocale == NULL ) {
192 return;
207 for( i = 0; i < LocaleListLength; i++ ) {
215 result = posixConverter->GetXPLocale(lc_temp, xpLocale);
220 result = posixConverter->GetXPLocale("en-US", xpLocale);
224 result = posixConverter->GetXPLocale(lang, xpLocale);
227 if (NS_FAILED(result)) {
this leaks resultLocale:
228 return;
i've built the osx branch but not the windows/os2 branch
Assignee: smontagu → timeless
Status: NEW → ASSIGNED
Attachment #498298 -
Flags: review?(smontagu)
Attachment #498298 -
Flags: approval2.0?
|
||
Updated•15 years ago
|
Attachment #498298 -
Flags: review?(smontagu) → review+
|
||
Updated•15 years ago
|
Attachment #498298 -
Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
|
||
Comment 2•15 years ago
|
||
|
||
Updated•7 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•