619824 - Dispatch a delayed mousemove event soon after TapDown

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Now that Electrolysis is in place we could safely dispatch a mousemove event soon after TapDown without fearing to regress panning, in fact this also fix a regression because before e10s we were doing delayed highlighting...

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

An example of a what this bug should resolve is https://bug460966.bugzilla.mozilla.org/attachment.cgi?id=344091 per bug 460966#c0

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 498241 [details] [diff] [review]
Patch


>diff --git a/chrome/content/input.js b/chrome/content/input.js

>+      this._mouseoverTimeout.once(kOverTapWait);

this._mouseOverTimeout.once(kOverTapWait);

>+  _doMouseover: function _doMouseover() {

_doMouseOver:

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/b716cf8defe8

Comment 4

[Aaron Train [:aaronmt]]

Any automated tests or ways to verify this?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #4)
> Any automated tests or ways to verify this?

I guess a browser-chrome test would be nice for it. I will do one in a few.

Comment 6

[Anna (Waverley)]

How can I verify this?

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

Verified - when clicking on https://bug460966.bugzilla.mozilla.org/attachment.cgi?id=344091 the sub menu appears while your finger is down where as on a build before Dec-16th the menu shows when your finger leaves the screen

Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110527 Firefox/7.0a1 Fennec/7.0a1 ID:20110527031218

Comment 8

[Dão Gottwald [:dao]]

bugspam