619931 - Exact tracer generator needs to provide more macro combinations

Status: RESOLVED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P2)

Description

[Lars T Hansen]

Specifically we need combinations of _WITH_HOOK and _IFDEF, etc.

Comment 1

[Lars T Hansen]

Attachment: Patch

Pretty straightforward, as the .hook and .ifdef properties on GCClass already compose; all we need is an update to the parser and two macro definitions in the C++ header file.

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

Comment on attachment 498340 [details] [diff] [review]
Patch

Looking at the whole set of macros, should we have IFNDEF variants of all of these?

Perhaps it is not necessary because we assume that we will never see class definitions in #ifndef blocks *nor* in #else blocks for #ifdef's?  So if it's a deliberate decision to leave this out, add a note saying so.

Comment 3

[Lars T Hansen]

(In reply to comment #2)
> Comment on attachment 498340 [details] [diff] [review]
> Patch
> 
> Looking at the whole set of macros, should we have IFNDEF variants of all of
> these?
> 
> Perhaps it is not necessary because we assume that we will never see class
> definitions in #ifndef blocks *nor* in #else blocks for #ifdef's?  So if it's a
> deliberate decision to leave this out, add a note saying so.

No, you're probably right - I'll add _IF and _IFNDEF variants and put it up for re-review.

Comment 4

[Lars T Hansen]

Attachment: Patch, v2

Updated to add _IFNDEF and _IF variants for both kinds of class annotations, with and without hooks.  This resulted in enough of an unreadable regex that I caved and reorganized the code locally but the change should be relatively transparent.  Also tweaked the exactgc cookbook.