Exact tracer generator needs to provide more macro combinations

RESOLVED FIXED in Q3 11 - Serrano

Status

P2
normal
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: lhansen, Assigned: lhansen)

Tracking

(Blocks: 1 bug)

unspecified
Q3 11 - Serrano
Dependency tree / graph
Bug Flags:
flashplayer-bug -

Details

(Whiteboard: has-patch)

Attachments

(1 attachment, 1 obsolete attachment)

8.04 KB, patch
pnkfelix
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Specifically we need combinations of _WITH_HOOK and _IFDEF, etc.
(Assignee)

Comment 1

8 years ago
Created attachment 498340 [details] [diff] [review]
Patch

Pretty straightforward, as the .hook and .ifdef properties on GCClass already compose; all we need is an update to the parser and two macro definitions in the C++ header file.
Attachment #498340 - Flags: review?(fklockii)
(Assignee)

Updated

8 years ago
Whiteboard: has-patch
Comment on attachment 498340 [details] [diff] [review]
Patch

Looking at the whole set of macros, should we have IFNDEF variants of all of these?

Perhaps it is not necessary because we assume that we will never see class definitions in #ifndef blocks *nor* in #else blocks for #ifdef's?  So if it's a deliberate decision to leave this out, add a note saying so.
Attachment #498340 - Flags: review?(fklockii) → review+
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> Comment on attachment 498340 [details] [diff] [review]
> Patch
> 
> Looking at the whole set of macros, should we have IFNDEF variants of all of
> these?
> 
> Perhaps it is not necessary because we assume that we will never see class
> definitions in #ifndef blocks *nor* in #else blocks for #ifdef's?  So if it's a
> deliberate decision to leave this out, add a note saying so.

No, you're probably right - I'll add _IF and _IFNDEF variants and put it up for re-review.
(Assignee)

Comment 4

8 years ago
Created attachment 500811 [details] [diff] [review]
Patch, v2

Updated to add _IFNDEF and _IF variants for both kinds of class annotations, with and without hooks.  This resulted in enough of an unreadable regex that I caved and reorganized the code locally but the change should be relatively transparent.  Also tweaked the exactgc cookbook.
Attachment #498340 - Attachment is obsolete: true
Attachment #500811 - Flags: review?(fklockii)
Attachment #500811 - Flags: review?(fklockii) → review+
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Flags: flashplayer-bug-
You need to log in before you can comment on or make changes to this bug.