Closed Bug 619980 Opened 9 years ago Closed 9 years ago

patcher-config-bump.pl and update-verify-bump.pl need to special case 64-bit platforms

Categories

(Release Engineering :: General, defect, P2)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: rail)

References

Details

Attachments

(3 files, 3 obsolete files)

...because Linux and Mac 64-bit are supposed to obey the platform exceptions for their 32-bit counterparts. Without these scripts supporting that, we don't generate updates for ja and ja-JP-mac on these platforms.
Priority: -- → P2
Will end up being done as part of 600931.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 600931
I doubt that Bug 600931 is going to be landed before Firefox 4.0b9. Reopening and grabbing the bug.
Assignee: bhearsum → rail
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Attached patch Bootstrap (obsolete) — Splinter Review
Attached patch tools (obsolete) — Splinter Review
Attached patch patcher-configsSplinter Review
This patch allows properly generate updates for ja/linux64. The updated patcher-config-bump.pl should properly handle linux64 after applying the remaining patches. Still testing in staging.
Attachment #501953 - Flags: review?(catlee)
Attachment #501954 - Flags: review?(catlee)
Attachment #501987 - Flags: review?(catlee)
Blocks: 621199
Attachment #501953 - Flags: review?(catlee) → review+
Attachment #501954 - Flags: review?(catlee) → review+
Attachment #501987 - Flags: review?(catlee) → review+
Attached patch Bootstrap (obsolete) — Splinter Review
Typo, s/macos/macosx/.
Attachment #501953 - Attachment is obsolete: true
Attachment #502100 - Flags: review+
Attached patch BootstrapSplinter Review
Thanks to coop's sharp eyes. :)

> +my %EQUAL_PLATFORMS = ('linux' => ['linux64'], 'osx' => ['osx64']);

We supposed to use shipped-locales platforms here, not buildbot platforms.

We also need a function to map FTP to buildbot platforms (GetFTPToBuildbotPlatformMap), see the next patch.
Attachment #502100 - Attachment is obsolete: true
Attachment #502503 - Flags: review?(catlee)
Attached patch toolsSplinter Review
> -            push(@supportedPatcherPlatforms, $platformMap{$platform});
> +            if (exists $FTPplatformMap{$platformMap{$platform}} &&
> +                grep($FTPplatformMap{$platformMap{$platform}} eq $_, @{$platforms})){
> +                    push(@supportedPatcherPlatforms, $platformMap{$platform});
> +            }

This is to make sure that we don't add platforms listed in shipped-locales, but not supported during the release. For example if we build mac64, mac won't be listed in exceptions.

> $FTPplatformMap{$platformMap{$equal_platform}}
 'mac64'         <- 'macosx64'  <- 'osx64'
 'linux-x86_64'  <- 'linux64'   <- 'linux64'

Converts (pseudo for osx64) shipped-locales platform (used in @{$localeInfo->{$locale}})  to buildbot, then to ftp (used in @{$platforms}) (!).
Attachment #501954 - Attachment is obsolete: true
Attachment #502506 - Flags: review?(catlee)
Bootstrap changes should be tagged with UPDATE_PACKAGING_R13, btw.
Attachment #502503 - Flags: review?(catlee) → review+
Attachment #502506 - Flags: review?(catlee) → review+
Comment on attachment 502503 [details] [diff] [review]
Bootstrap

Landed on _R13:
Checking in Util.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Util.pm,v  <--  Util.pm
new revision: 1.19; previous revision: 1.18
done
ssh-agent[] bhearsum@voot:~/Mozilla/checkouts/tools-mirror/release/Bootstrap$ ssh-agent
SSH_AUTH_SOCK=/tmp/ssh-JSgxN16326/agent.16326; export SSH_AUTH_SOCK;
SSH_AGENT_PID=16327; export SSH_AGENT_PID;
echo Agent pid 16327;
[] bhearsum@voot:~/Mozilla/checkouts/tools-mirror/release/Bootstrap$ cvs tag UPDATE_PACKAGING_R13 Util.pm
Enter passphrase for key '/home/bhearsum/.ssh/id_dsa': 
W Util.pm : UPDATE_PACKAGING_R13 already exists on version 1.18 : NOT MOVING tag to version 1.19
[] bhearsum@voot:~/Mozilla/checkouts/tools-mirror/release/Bootstrap$ cvs tag -F UPDATE_PACKAGING_R13 Util.pm
Enter passphrase for key '/home/bhearsum/.ssh/id_dsa': 
T Util.pm

And on _R11_1:
Checking in Util.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Util.pm,v  <--  Util.pm
new revision: 1.18.2.1; previous revision: 1.18
done
[] bhearsum@voot:~/Mozilla/checkouts/tools-mirror/release/Bootstrap$ cvs tag UPDATE_PACKAGING_R11_1 Util.pm
Enter passphrase for key '/home/bhearsum/.ssh/id_dsa': 
W Util.pm : UPDATE_PACKAGING_R11_1 already exists on version 1.18 : NOT MOVING tag to version 1.18.2.1
[] bhearsum@voot:~/Mozilla/checkouts/tools-mirror/release/Bootstrap$ cvs tag -F UPDATE_PACKAGING_R11_1 Util.pm
Enter passphrase for key '/home/bhearsum/.ssh/id_dsa': 
T Util.pm
Attachment #502503 - Flags: checked-in+
Comment on attachment 501987 [details] [diff] [review]
patcher-configs

Checking in moz20-branch-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/moz20-branch-patcher2.cfg,v  <--  moz20-branch-patcher2.cfg
new revision: 1.13; previous revision: 1.12
done
Attachment #501987 - Flags: checked-in+
Silly typo in Bootstrap/Util.pm:

-                    GetFTPToBuildbotiPlatformMap);
+                    GetFTPToBuildbotPlatformMap);

To get updates working asap, I had to fix this w/o a review and commited to CVS using cltbld. Tags have been also updated.
All done here.
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Blocks: 627271
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.