Closed
Bug 619980
Opened 14 years ago
Closed 13 years ago
patcher-config-bump.pl and update-verify-bump.pl need to special case 64-bit platforms
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: rail)
References
Details
Attachments
(3 files, 3 obsolete files)
2.61 KB,
patch
|
catlee
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
2.40 KB,
patch
|
catlee
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
4.73 KB,
patch
|
catlee
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
...because Linux and Mac 64-bit are supposed to obey the platform exceptions for their 32-bit counterparts. Without these scripts supporting that, we don't generate updates for ja and ja-JP-mac on these platforms.
Reporter | ||
Updated•14 years ago
|
Priority: -- → P2
Reporter | ||
Comment 1•14 years ago
|
||
Will end up being done as part of 600931.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 2•14 years ago
|
||
I doubt that Bug 600931 is going to be landed before Firefox 4.0b9. Reopening and grabbing the bug.
Assignee: bhearsum → rail
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Comment 3•14 years ago
|
||
Assignee | ||
Comment 4•14 years ago
|
||
Assignee | ||
Comment 5•14 years ago
|
||
This patch allows properly generate updates for ja/linux64. The updated patcher-config-bump.pl should properly handle linux64 after applying the remaining patches. Still testing in staging.
Assignee | ||
Updated•14 years ago
|
Attachment #501953 -
Flags: review?(catlee)
Assignee | ||
Updated•14 years ago
|
Attachment #501954 -
Flags: review?(catlee)
Assignee | ||
Updated•14 years ago
|
Attachment #501987 -
Flags: review?(catlee)
Updated•14 years ago
|
Attachment #501953 -
Flags: review?(catlee) → review+
Updated•14 years ago
|
Attachment #501954 -
Flags: review?(catlee) → review+
Updated•14 years ago
|
Attachment #501987 -
Flags: review?(catlee) → review+
Assignee | ||
Comment 6•14 years ago
|
||
Typo, s/macos/macosx/.
Attachment #501953 -
Attachment is obsolete: true
Attachment #502100 -
Flags: review+
Assignee | ||
Comment 7•14 years ago
|
||
Thanks to coop's sharp eyes. :)
> +my %EQUAL_PLATFORMS = ('linux' => ['linux64'], 'osx' => ['osx64']);
We supposed to use shipped-locales platforms here, not buildbot platforms.
We also need a function to map FTP to buildbot platforms (GetFTPToBuildbotPlatformMap), see the next patch.
Attachment #502100 -
Attachment is obsolete: true
Attachment #502503 -
Flags: review?(catlee)
Assignee | ||
Comment 8•14 years ago
|
||
> - push(@supportedPatcherPlatforms, $platformMap{$platform}); > + if (exists $FTPplatformMap{$platformMap{$platform}} && > + grep($FTPplatformMap{$platformMap{$platform}} eq $_, @{$platforms})){ > + push(@supportedPatcherPlatforms, $platformMap{$platform}); > + } This is to make sure that we don't add platforms listed in shipped-locales, but not supported during the release. For example if we build mac64, mac won't be listed in exceptions. > $FTPplatformMap{$platformMap{$equal_platform}} 'mac64' <- 'macosx64' <- 'osx64' 'linux-x86_64' <- 'linux64' <- 'linux64' Converts (pseudo for osx64) shipped-locales platform (used in @{$localeInfo->{$locale}}) to buildbot, then to ftp (used in @{$platforms}) (!).
Attachment #501954 -
Attachment is obsolete: true
Attachment #502506 -
Flags: review?(catlee)
Assignee | ||
Comment 9•14 years ago
|
||
Bootstrap changes should be tagged with UPDATE_PACKAGING_R13, btw.
Updated•14 years ago
|
Attachment #502503 -
Flags: review?(catlee) → review+
Updated•14 years ago
|
Attachment #502506 -
Flags: review?(catlee) → review+
Reporter | ||
Comment 10•14 years ago
|
||
Comment on attachment 502503 [details] [diff] [review] Bootstrap Landed on _R13: Checking in Util.pm; /cvsroot/mozilla/tools/release/Bootstrap/Util.pm,v <-- Util.pm new revision: 1.19; previous revision: 1.18 done ssh-agent[] bhearsum@voot:~/Mozilla/checkouts/tools-mirror/release/Bootstrap$ ssh-agent SSH_AUTH_SOCK=/tmp/ssh-JSgxN16326/agent.16326; export SSH_AUTH_SOCK; SSH_AGENT_PID=16327; export SSH_AGENT_PID; echo Agent pid 16327; [] bhearsum@voot:~/Mozilla/checkouts/tools-mirror/release/Bootstrap$ cvs tag UPDATE_PACKAGING_R13 Util.pm Enter passphrase for key '/home/bhearsum/.ssh/id_dsa': W Util.pm : UPDATE_PACKAGING_R13 already exists on version 1.18 : NOT MOVING tag to version 1.19 [] bhearsum@voot:~/Mozilla/checkouts/tools-mirror/release/Bootstrap$ cvs tag -F UPDATE_PACKAGING_R13 Util.pm Enter passphrase for key '/home/bhearsum/.ssh/id_dsa': T Util.pm And on _R11_1: Checking in Util.pm; /cvsroot/mozilla/tools/release/Bootstrap/Util.pm,v <-- Util.pm new revision: 1.18.2.1; previous revision: 1.18 done [] bhearsum@voot:~/Mozilla/checkouts/tools-mirror/release/Bootstrap$ cvs tag UPDATE_PACKAGING_R11_1 Util.pm Enter passphrase for key '/home/bhearsum/.ssh/id_dsa': W Util.pm : UPDATE_PACKAGING_R11_1 already exists on version 1.18 : NOT MOVING tag to version 1.18.2.1 [] bhearsum@voot:~/Mozilla/checkouts/tools-mirror/release/Bootstrap$ cvs tag -F UPDATE_PACKAGING_R11_1 Util.pm Enter passphrase for key '/home/bhearsum/.ssh/id_dsa': T Util.pm
Attachment #502503 -
Flags: checked-in+
Assignee | ||
Comment 11•14 years ago
|
||
Comment on attachment 502506 [details] [diff] [review] tools http://hg.mozilla.org/build/tools/rev/e1b38c981a63
Attachment #502506 -
Flags: checked-in+
Reporter | ||
Comment 12•14 years ago
|
||
Comment on attachment 501987 [details] [diff] [review] patcher-configs Checking in moz20-branch-patcher2.cfg; /cvsroot/mozilla/tools/patcher-configs/moz20-branch-patcher2.cfg,v <-- moz20-branch-patcher2.cfg new revision: 1.13; previous revision: 1.12 done
Attachment #501987 -
Flags: checked-in+
Assignee | ||
Comment 13•14 years ago
|
||
Silly typo in Bootstrap/Util.pm: - GetFTPToBuildbotiPlatformMap); + GetFTPToBuildbotPlatformMap); To get updates working asap, I had to fix this w/o a review and commited to CVS using cltbld. Tags have been also updated.
Assignee | ||
Comment 14•13 years ago
|
||
All done here.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 13 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•