619995 - Sync Options dialog hangs if choose "Replace all data on this computer"

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Comment 1

[Jason Duell]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20101216 Firefox/4.0b9pre

Installed Minefield on brand new Windoze 7 Home Ed. laptop.  Trying to hook it up with my existing Sync account via "Set up Sync" | "I already have a Sync Account" | "Sync Options". The Sync Options dialog's "Done" button does nothing if I've changed the default "Recommended: merge data" to "Replace this machine's data with Sync data." If I change the radio button back to the recommended setting, the "Done" button works again. 

Smells like a blocker to me.

Comment 2

[Philipp von Weitershausen [:philikon]]

Yup, there's some places SQL in the UI code (*facepalm*) that we failed to update to the temp table deletion that landed as part of the places branch merge. Yay for no UI tests!

We should really move this code out of the UI and into the respective engines. UI code can then use Weave.Engines.get(...).getCount() or something.

This should block b9.

Comment 4

[Philipp von Weitershausen [:philikon]]

Attachment: v1

This just fixes the issue at hand. Filed bug 620577 for cleaning up this code properly (move the SQL code to services/sync/)

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 498911 [details] [diff] [review]
v1

bah.

Comment 8

[LegNeato]

As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)

Comment 9

[LegNeato]

Fixing fields my automated script accidentally blanked. Apologies for the bugspam

Comment 10

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/44135a071244

Comment 11

[Tracy Walker [:tracy]]

Works on 1.6.1. Will wait for next nightly to verify trunk.

Comment 12

[Philipp von Weitershausen [:philikon]]

(In reply to comment #11)
> Works on 1.6.1.

This never affected the add-on in the first place.

Comment 13

[Igor Velkov]

Addon was affected with SeaMonkey.

Comment 14

[Philipp von Weitershausen [:philikon]]

(In reply to comment #13)
> Addon was affected with SeaMonkey.

Please file a new bug for that. This bug is about the *Firefox* UI.