Closed Bug 620070 Opened 14 years ago Closed 14 years ago

Permaorange - js1_5/extensions/regress-342960.js - No test results reported. (SCRIPT)

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: philor, Assigned: philor)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #528464 +++ Bug 528464 disabled the test on Windows, and it was previously disabled on Linux, and now some part of http://hg.mozilla.org/tracemonkey/pushloghtml?fromchange=df86d5999fef&tochange=1d1fe1d1e626 has allowed it to quietly OOM on Mac, so it's now failing what looks like every time, so far, on 10.5 opt. Luke says it looks to him like it should be silentfail like the other things in there that can silently fail from OOM. I can't remember back a year, to know whether that was actually the problem that caused us to shut it off for Windows. http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1292639505.1292640076.12828.gz http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1292637514.1292638147.5432.gz
Attached patch silentfailSplinter Review
Patched off a mozilla-central tree since I don't have a TraceMonkey tree, but I assume it'll work.
Assignee: general → philringnalda
Status: NEW → ASSIGNED
Attachment #498622 - Flags: review?(bclary)
Comment on attachment 498622 [details] [diff] [review] silentfail Looks good. Applies cleanly to tracemonkey which is where you want it right? Do you need someone to check it in ?
Attachment #498622 - Flags: review?(bclary) → review+
Yep, I do need checkin-needed - cloning a TM tree over a 3G connection just doesn't sound like fun :)
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
mmm, green. thanks for the push.
Status: RESOLVED → VERIFIED
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: