Closed Bug 620171 Opened 9 years ago Closed 8 years ago

[@ ImageContainerOGL::GetCurrentAsSurface] if GetFormat() can return anything other than PLANAR_YCBCR or CAIRO_SURFACE

Categories

(Core :: Canvas: WebGL, defect, critical)

x86
Windows 7
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, crash)

Crash Data

Attachments

(1 file)

250 ImageContainerOGL::GetCurrentAsSurface(gfxIntSize *aSize)

259   GLContext *gl = nsnull;

let mActiveImage->GetFormat() be neither PLANAR_YCBCR nor CAIRO_SURFACE:
264   if (mActiveImage->GetFormat() == Image::PLANAR_YCBCR) {
292   }

294   if (mActiveImage->GetFormat() == Image::CAIRO_SURFACE) {
skipped:
298     gl = cairoImage->mTexture.GetGLContext();

crash here:
302   nsRefPtr<gfxImageSurface> s = gl->ReadTextureImage(tex1, size, LOCAL_GL_RGBA);
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498585 - Flags: review?(bas.schouten)
Attachment #498585 - Flags: approval2.0?
Comment on attachment 498585 [details] [diff] [review]
patch

Please request approval only after you've gotten review.
Attachment #498585 - Flags: approval2.0?
Crash Signature: [@ ImageContainerOGL::GetCurrentAsSurface]
Attachment #498585 - Flags: review?(bas.schouten) → review?(bgirard)
Attachment #498585 - Flags: review?(bgirard) → review+
In my queue with a few other bits that are being sent to try first and then onto inbound :-)

https://tbpl.mozilla.org/?tree=Try&rev=c1528769b893
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fc4e4fa98b14
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.