[@ ImageContainerOGL::GetCurrentAsSurface] if GetFormat() can return anything other than PLANAR_YCBCR or CAIRO_SURFACE

RESOLVED FIXED in mozilla10

Status

()

Core
Canvas: WebGL
--
critical
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({coverity, crash})

Trunk
mozilla10
x86
Windows 7
coverity, crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
250 ImageContainerOGL::GetCurrentAsSurface(gfxIntSize *aSize)

259   GLContext *gl = nsnull;

let mActiveImage->GetFormat() be neither PLANAR_YCBCR nor CAIRO_SURFACE:
264   if (mActiveImage->GetFormat() == Image::PLANAR_YCBCR) {
292   }

294   if (mActiveImage->GetFormat() == Image::CAIRO_SURFACE) {
skipped:
298     gl = cairoImage->mTexture.GetGLContext();

crash here:
302   nsRefPtr<gfxImageSurface> s = gl->ReadTextureImage(tex1, size, LOCAL_GL_RGBA);
(Assignee)

Comment 1

7 years ago
Created attachment 498585 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498585 - Flags: review?(bas.schouten)
Attachment #498585 - Flags: approval2.0?
Comment on attachment 498585 [details] [diff] [review]
patch

Please request approval only after you've gotten review.
Attachment #498585 - Flags: approval2.0?
Crash Signature: [@ ImageContainerOGL::GetCurrentAsSurface]

Updated

6 years ago
Attachment #498585 - Flags: review?(bas.schouten) → review?(bgirard)

Updated

6 years ago
Attachment #498585 - Flags: review?(bgirard) → review+

Updated

6 years ago
Keywords: checkin-needed
In my queue with a few other bits that are being sent to try first and then onto inbound :-)

https://tbpl.mozilla.org/?tree=Try&rev=c1528769b893
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc4e4fa98b14
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/fc4e4fa98b14
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.