Last Comment Bug 620171 - [@ ImageContainerOGL::GetCurrentAsSurface] if GetFormat() can return anything other than PLANAR_YCBCR or CAIRO_SURFACE
: [@ ImageContainerOGL::GetCurrentAsSurface] if GetFormat() can return anything...
Status: RESOLVED FIXED
: coverity, crash
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: Trunk
: x86 Windows 7
: -- critical (vote)
: mozilla10
Assigned To: timeless
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-18 15:33 PST by timeless
Modified: 2011-10-10 11:14 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.22 KB, patch)
2010-12-19 02:13 PST, timeless
bgirard: review+
Details | Diff | Review

Description timeless 2010-12-18 15:33:17 PST
250 ImageContainerOGL::GetCurrentAsSurface(gfxIntSize *aSize)

259   GLContext *gl = nsnull;

let mActiveImage->GetFormat() be neither PLANAR_YCBCR nor CAIRO_SURFACE:
264   if (mActiveImage->GetFormat() == Image::PLANAR_YCBCR) {
292   }

294   if (mActiveImage->GetFormat() == Image::CAIRO_SURFACE) {
skipped:
298     gl = cairoImage->mTexture.GetGLContext();

crash here:
302   nsRefPtr<gfxImageSurface> s = gl->ReadTextureImage(tex1, size, LOCAL_GL_RGBA);
Comment 1 timeless 2010-12-19 02:13:18 PST
Created attachment 498585 [details] [diff] [review]
patch
Comment 2 Joe Drew (not getting mail) 2011-01-31 13:23:16 PST
Comment on attachment 498585 [details] [diff] [review]
patch

Please request approval only after you've gotten review.
Comment 3 Ed Morley [:emorley] 2011-10-10 00:19:24 PDT
In my queue with a few other bits that are being sent to try first and then onto inbound :-)

https://tbpl.mozilla.org/?tree=Try&rev=c1528769b893
Comment 5 Matt Brubeck (:mbrubeck) 2011-10-10 11:14:43 PDT
https://hg.mozilla.org/mozilla-central/rev/fc4e4fa98b14

Note You need to log in before you can comment on or make changes to this bug.