Closed Bug 620179 Opened 9 years ago Closed 9 years ago

crash [@ TestNode::Constrain] if cantHandleYet

Categories

(Core :: XUL, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, crash)

Crash Data

Attachments

(1 file, 1 obsolete file)

836 bytes, patch
timeless
: review+
beltzner
: approval2.0-
Details | Diff | Splinter Review
410 TestNode::Constrain(InstantiationSet& aInstantiations)
426     if ((mParent && ! aInstantiations.Empty()) || cantHandleYet) {
434         rv = mParent->Constrain(aInstantiations);
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498574 - Flags: review?(neil)
Comment on attachment 498574 [details] [diff] [review]
patch

You want the other Neil for templates.
Attachment #498574 - Flags: review?(neil) → review?(enndeakin)
Attachment #498574 - Flags: review?(enndeakin) → review+
Attached patch r=ennSplinter Review
Attachment #498574 - Attachment is obsolete: true
Attachment #499192 - Flags: review+
Attachment #499192 - Flags: approval2.0?
Comment on attachment 499192 [details] [diff] [review]
r=enn

Unless there's evidence that this actually causes crashes, I'm not sure we want the risk here. Renominate if I'm overestimating the risk ...
Attachment #499192 - Flags: approval2.0? → approval2.0-
http://hg.mozilla.org/mozilla-central/rev/e860870e399e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Crash Signature: [@ TestNode::Constrain]
You need to log in before you can comment on or make changes to this bug.