620183 - nsHttpChannel::CheckCache should cache requestedETag (If_Match) the first time

Status: RESOLVED INCOMPLETE

(Core :: Networking: HTTP, enhancement)

Description

[timeless]

2430 nsHttpChannel::CheckCache()
2608         const char *requestedETag, *cachedETag;
2609         cachedETag = mCachedResponseHead->PeekHeader(nsHttp::ETag);
2610         requestedETag = mRequestHead.PeekHeader(nsHttp::If_Match);
2611         if (cachedETag && (!strncmp(cachedETag, "W/", 2) ||
2612             strcmp(requestedETag, cachedETag))) {

Comment 1

[timeless]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

This code is inside this if condition:
 
2606     if (!doValidation && mRequestHead.PeekHeader(nsHttp::If_Match) &&
2607         (method == nsHttp::Get || method == nsHttp::Head)) {

so requestedETag can't be null here; we just checked it above!

Comment 3

[timeless]

Attachment: cache

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 499398 [details] [diff] [review]
cache

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 499398 [details] [diff] [review]
cache

I find this hard to read. please move the assignment outside the if condition.