620184 - remove null checks from GetDOMSlots() and rename it to DOMSlots() because it is infallible in m-c

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[timeless]

248 nsStyledElement::GetStyle(nsresult* retval)
259   nsGenericElement::nsDOMSlots *slots = GetDOMSlots();

261   if (!slots->mStyle) {

this is the only place which doesn't null check GetDOMSlots(), coverity thinks this is suspicious.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

It looks to me like slots creation uses infallible malloc (nsINode::CreateSlots), and therefore the things that null-check it all shouldn't be null-checking it anymore.

That said, before we had infallible malloc this does look like a valid OOM crash bug.

Comment 2

[timeless]

afaict 1.9.2 and 1.9.1 have null checks there

Comment 3

[timeless]

Attachment: remove checks

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 498581 [details] [diff] [review]
remove checks

Please also rename the function to DOMSlots(). We usually drop the "Get" for functions that never return null.

Comment 5

[timeless]

Attachment: DOMSlots()

Comment 6

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/e27527551d57