Closed
Bug 620206
Opened 14 years ago
Closed 13 years ago
nsFrameMessageManager::ReceiveMessage returns non-nsresult values
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
People
(Reporter: jdm, Unassigned)
Details
Attachments
(1 file)
|
1.87 KB,
patch
|
smaug
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
>nsresult >nsFrameMessageManager::ReceiveMessage(nsISupports* aTarget, ... > if (!aObjectsArray) { > return false; > } ... > if (!ac.enter(ctx, object)) > return PR_FALSE;
|
||
Comment 1•14 years ago
|
||
Oops :)
|
Reporter | |
Comment 2•13 years ago
|
||
Attachment #510775 -
Flags: review?(Olli.Pettay)
|
|
||
Updated•13 years ago
|
Attachment #510775 -
Flags: review?(Olli.Pettay) → review+
|
|
Reporter | |
Comment 3•13 years ago
|
||
Comment on attachment 510775 [details] [diff] [review] Make nsFrameMessageManager::ReceiveMessage return consistent error values. The current code is wrong. This is both safe and correct.
Attachment #510775 -
Flags: approval2.0?
|
||
Updated•13 years ago
|
Attachment #510775 -
Flags: approval2.0? → approval2.0+
|
|
Reporter | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/8be99120130a
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
You need to log in
before you can comment on or make changes to this bug.
Description
•