Allow a product name to be set on makeLogUploadCommand

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
makeLogUploadCommand doesn't take or forward a product name to feed to log_uploader.py, and so that defaults to "firefox", which in turn causes reports of error like this in the SeaMonkey builder logs now that we synced this up with what Firefox uses:

        OSError: [Errno 13] Permission denied: '/home/ftp/pub/firefox/tinderbox-builds/comm-central-trunk-macosx64-debug'

(I'm leaving out the rest of the error as I could track it down easily to what I'm saying in the start of this comment.)

I should have a patch around, I'll test before attaching if the SeaMonkey buildmaster likes it, though.
(Assignee)

Comment 1

7 years ago
Created attachment 498615 [details] [diff] [review]
add product parameter

Here's the patch, looks good from what I see on the SeaMonkey buildmaster. This adds a product parameter and adds it for the call from the CC side.
Attachment #498615 - Flags: review?(bhearsum)
Attachment #498615 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 2

7 years ago
Thanks, landed as http://hg.mozilla.org/build/buildbotcustom/rev/cb0d3af49235
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.