620230 - Allow a product name to be set on makeLogUploadCommand

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Kaiser]

makeLogUploadCommand doesn't take or forward a product name to feed to log_uploader.py, and so that defaults to "firefox", which in turn causes reports of error like this in the SeaMonkey builder logs now that we synced this up with what Firefox uses:

        OSError: [Errno 13] Permission denied: '/home/ftp/pub/firefox/tinderbox-builds/comm-central-trunk-macosx64-debug'

(I'm leaving out the rest of the error as I could track it down easily to what I'm saying in the start of this comment.)

I should have a patch around, I'll test before attaching if the SeaMonkey buildmaster likes it, though.

Comment 1

[Robert Kaiser]

Attachment: add product parameter

Here's the patch, looks good from what I see on the SeaMonkey buildmaster. This adds a product parameter and adds it for the call from the CC side.

Comment 2

[Robert Kaiser]

Thanks, landed as http://hg.mozilla.org/build/buildbotcustom/rev/cb0d3af49235