620250 - crash [@ vorbis_dsp_clear] if !vi

Status: VERIFIED WORKSFORME

(Core :: Audio/Video, defect)

Description

[timeless]

235 void vorbis_dsp_clear(vorbis_dsp_state *v){
236   int i;
237   if(v){
238     vorbis_info *vi=v->vi;
this code worries that vi might be null:
239     codec_setup_info *ci=(codec_setup_info *)(vi?vi->codec_setup:NULL);
240     private_state *b=(private_state *)v->backend_state;
241 
242     if(v->pcm){
this code simply crashes:
243       for(i=0;i<vi->channels;i++)

Comment 1

[Timothy B. Terriberry (:derf)]

vi can't be NULL if pcm is non-NULL. vi->channels is required to allocate pcm in the first place.

Comment 2

[timeless]

ok, kinda unfortunate, i'm likely to be switching to a new coverity in the future at which point any annotations i make in the current one will be lost.