620252 - RomanToText could use // FALLTHROUGH comments for 3 and 2

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement)

Description

[timeless]

452 static PRBool RomanToText(PRInt32 ordinal, nsString& result, const char* achars, const char* bchars)
453 {
454   if (ordinal < 1 || ordinal > 3999) {
455     DecimalToText(ordinal, result);
456     return PR_FALSE;
457   }
458   nsAutoString addOn, decStr;
459   decStr.AppendInt(ordinal, 10);
460   PRIntn len = decStr.Length();
461   const PRUnichar* dp = decStr.get();
462   const PRUnichar* end = dp + len;
463   PRIntn romanPos = len;
464   PRIntn n;
465 
466   for (; dp < end; dp++) {
467     romanPos--;
468     addOn.SetLength(0);
469     switch(*dp) {
coverity complains about cases '3' and '2':
470       case '3':  addOn.Append(PRUnichar(achars[romanPos]));
471       case '2':  addOn.Append(PRUnichar(achars[romanPos]));
472       case '1':  addOn.Append(PRUnichar(achars[romanPos]));
473         break;
it doesn't complain about case '4' because there's a fallthrough comment which it understands:
474       case '4':
475         addOn.Append(PRUnichar(achars[romanPos]));
476         // FALLTHROUGH
477       case '5': case '6':
478       case '7': case  '8':
479         addOn.Append(PRUnichar(bchars[romanPos]));
480         for(n=0;'5'+n<*dp;n++) {
481           addOn.Append(PRUnichar(achars[romanPos]));
482         }
483         break;
484       case '9':
485         addOn.Append(PRUnichar(achars[romanPos]));
486         addOn.Append(PRUnichar(achars[romanPos+1]));
487         break;
488       default:
489         break;
490     }

Comment 1

[timeless]

Attachment: add fallthrough comments

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 498670 [details] [diff] [review]
add fallthrough comments

r=dbaron

Comment 3

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/3aab15091aa0