Closed Bug 620255 Opened 9 years ago Closed 9 years ago

add comment nsHTMLInputElement::PostHandleEvent for isMovingBack falling through

Categories

(Core :: Layout: Form Controls, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b9

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(1 file)

2107 nsHTMLInputElement::PostHandleEvent(nsEventChainPostVisitor& aVisitor)
2331             switch (keyEvent->keyCode) {
2332               case NS_VK_UP: 
2333               case NS_VK_LEFT:
2334                 isMovingBack = PR_TRUE;

inserting a comment here will enable static analysis tools to understand that you are intentionally falling through.

2335               case NS_VK_DOWN:
2336               case NS_VK_RIGHT:
2337               // Arrow key pressed, focus+select prev/next radio button
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498672 - Flags: review?(dbaron)
Attachment #498672 - Flags: approval2.0?
Comment on attachment 498672 [details] [diff] [review]
add fallthrough comment

r=dbaron
Attachment #498672 - Flags: review?(dbaron)
Attachment #498672 - Flags: review+
Attachment #498672 - Flags: approval2.0?
Attachment #498672 - Flags: approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/24b63f638579
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in before you can comment on or make changes to this bug.