620260 - add fall through comment to nsHTTPCompressConv::OnDataAvailable

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement)

Description

[timeless]

131 nsHTTPCompressConv::OnDataAvailable(nsIRequest* request, 
155     switch (mMode)
156     {
157         case HTTP_COMPRESS_GZIP:
158             streamLen = check_header(iStr, streamLen, &rv);
159 
160             if (rv != NS_OK)
161                 return rv;
162 
163             if (streamLen == 0)
164                 return NS_OK;

adding a fall through saves reading

166         case HTTP_COMPRESS_DEFLATE:
167 
193             if (mMode == HTTP_COMPRESS_DEFLATE)
194             {
278             }
279             else
280             {

specifically here's the first comment hint that the fall through is correct:
337             } /* gzip */
338             break;

Comment 1

[timeless]

Attachment: add fallthrough comment

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 498676 [details] [diff] [review]
add fallthrough comment

can you make this a lowercase "fallthrough"?

Comment 3

[timeless]

it can be spelled 'fall through' or 'fallthrough' or written in german/dutch, coverity doesn't care what it says - any comment indicates to coverity that you're "aware" that it's doing this.

so tell me how you want it written and i (or someone else) can post a patch (or just fix it at push...)

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 498676 [details] [diff] [review]
add fallthrough comment

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.

Comment 5

[(no longer active)]

http://hg.mozilla.org/projects/cedar/rev/a3e8e7065858

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/a3e8e7065858