add fall through comment to nsHTTPCompressConv::OnDataAvailable

RESOLVED FIXED in mozilla5

Status

()

--
enhancement
RESOLVED FIXED
8 years ago
5 months ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
mozilla5
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
131 nsHTTPCompressConv::OnDataAvailable(nsIRequest* request, 
155     switch (mMode)
156     {
157         case HTTP_COMPRESS_GZIP:
158             streamLen = check_header(iStr, streamLen, &rv);
159 
160             if (rv != NS_OK)
161                 return rv;
162 
163             if (streamLen == 0)
164                 return NS_OK;

adding a fall through saves reading

166         case HTTP_COMPRESS_DEFLATE:
167 
193             if (mMode == HTTP_COMPRESS_DEFLATE)
194             {
278             }
279             else
280             {

specifically here's the first comment hint that the fall through is correct:
337             } /* gzip */
338             break;
(Assignee)

Comment 1

8 years ago
Created attachment 498676 [details] [diff] [review]
add fallthrough comment
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498676 - Flags: review?(cbiesinger)
Attachment #498676 - Flags: approval2.0?
Comment on attachment 498676 [details] [diff] [review]
add fallthrough comment

can you make this a lowercase "fallthrough"?
Attachment #498676 - Flags: review?(cbiesinger) → review+
(Assignee)

Comment 3

8 years ago
it can be spelled 'fall through' or 'fallthrough' or written in german/dutch, coverity doesn't care what it says - any comment indicates to coverity that you're "aware" that it's doing this.

so tell me how you want it written and i (or someone else) can post a patch (or just fix it at push...)
Comment on attachment 498676 [details] [diff] [review]
add fallthrough comment

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Attachment #498676 - Flags: approval2.0? → approval2.0-

Comment 5

8 years ago
http://hg.mozilla.org/projects/cedar/rev/a3e8e7065858
Whiteboard: fixed-in-cedar

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/a3e8e7065858
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.