620291 - useless assert of free_block [@ CodeAlloc::free]

Status: RESOLVED FIXED

(Core Graveyard :: Nanojit, defect)

Description

[timeless]

147     void CodeAlloc::free(NIns* start, NIns *end) {

182                     CodeList* free_block = availblocks;

there's no point in using free_block as a loop control:
183                     while ( free_block && free_block->next != coalescedBlock) {
184                         NanoAssert(free_block->size() >= minAllocSize);
185                         NanoAssert(free_block->isFree);
186                         NanoAssert(free_block->next);
187                         free_block = free_block->next;
188                     }
or asserting it:
189                     NanoAssert(free_block && free_block->next == coalescedBlock);

if you're just going to crash anyway:
190                     free_block->next = coalescedBlock->next;

Comment 1

[timeless]

Attachment: drop null checks

Comment 2

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/tracemonkey/rev/a26c9e7823e4

Comment 3

[Phil Ringnalda (:philor)]

Urg, and backed out in http://hg.mozilla.org/tracemonkey/rev/8e517eae885d when I suddenly realized *why* edwsmith was reviewing it. Maybe if it's in the nanojit component, I'll realize it's not something I want to push.

Comment 4

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/a26c9e7823e4
Note: not marking as fixed because fixed-in-tracemonkey is not present on the whiteboard.

Comment 5

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/8e517eae885d (backout)

Comment 6

[Rob Campbell [:rc] (:robcee)]

this was backed-out but still has a checkin-needed flag. Needs fixin'?

Comment 7

[timeless]

i think it's something that would want to be pushed or managed by someone from nanojit to a nanojit tree instead of to a tracemonkey/m-c tree.

Comment 8

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/projects/nanojit-central/rev/265c59717027

Comment 9

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/tracemonkey/rev/f7f0892c9807

Comment 10

[Tamarin Bot]

changeset: 6079:aaee24b632ed
user:      [e-mail]
summary:   Bug 620291 - useless assert of free_block [@ CodeAlloc::free].  r=gal,edwsmith.

http://hg.mozilla.org/tamarin-redux/rev/aaee24b632ed