620296 - Traceback in search API

Status: VERIFIED FIXED

(Input :: General, defect, P2)

Description

[Fred Wenzel [:wenzel]]

There seems to be an AssertionError for page 0 in our search:

----

Traceback (most recent call last):

  File "/data/www/django/input.mozilla.com/reporter/vendor/packages/Django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/django/input.mozilla.com/reporter/vendor/packages/Django/django/utils/decorators.py", line 76, in _wrapped_view
    response = view_func(request, *args, **kwargs)

  File "/data/www/django/input.mozilla.com/reporter/apps/input/decorators.py", line 33, in cached_view
    return f(request, *args, **kwargs)

  File "/data/www/django/input.mozilla.com/reporter/apps/search/views.py", line 123, in index
    request, meta=meta)

  File "/data/www/django/input.mozilla.com/reporter/apps/search/views.py", line 33, in _get_results
    opinions = c.query(query, **search_opts)

  File "/data/www/django/input.mozilla.com/reporter/apps/search/client.py", line 162, in query
    sc.SetLimits(min(SPHINX_HARD_LIMIT/limit, offset), limit)

  File "/data/www/django/input.mozilla.com/reporter/apps/search/sphinxapi.py", line 278, in SetLimits
    assert ( type(offset) in [int,long] and 0<=offset<16777216 )

AssertionError


<WSGIRequest
GET:<QueryDict: {u'locale': [u'en-US'], u'product': [u'firefox'], u'version': [u'4.0b7'], u'os': [u'linux'], u'page': [u'0']}>,
POST:<QueryDict: {}>,
COOKIES:{'SSID': 'AwC9xykAAAQAZl-aTAHsCQFNGOdLCAAAAAAAAAAAAAAAAACp6rhMAAAM_v__AAAAAAAEAAAA',
 'SSRT': 'nu64TAE',
 'WT_FPC': 'id=2be98c05865edcd3f6e1292634417239:lv=1292634417239:ss=1292634417239',
 'csrftoken': 'aeb22fb83314c67c11dea59ab9831366',
 's_vi': '',
 'wtspl': '997792'},
META:{'CSRF_COOKIE': 'aeb22fb83314c67c11dea59ab9831366',
 'DOCUMENT_ROOT': '/data/www/django/input.mozilla.com/reporter',
 'GATEWAY_INTERFACE': 'CGI/1.1',
 'HTTP_ACCEPT': 'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8',
 'HTTP_ACCEPT_CHARSET': 'ISO-8859-1,utf-8;q=0.7,*;q=0.7',
 'HTTP_ACCEPT_ENCODING': 'gzip, deflate',
 'HTTP_ACCEPT_LANGUAGE': 'en-us,en;q=0.5',
 'HTTP_CONNECTION': 'keep-alive',
 'HTTP_COOKIE': 'SSID=AwC9xykAAAQAZl-aTAHsCQFNGOdLCAAAAAAAAAAAAAAAAACp6rhMAAAM_v__AAAAAAAEAAAA; s_vi=[CS]v1|25F9665085010C0E-4000010260000422[CE]; SSRT=nu64TAE; wtspl=997792; WT_FPC=id=2be98c05865edcd3f6e1292634417239:lv=1292634417239:ss=1292634417239; csrftoken=aeb22fb83314c67c11dea59ab9831366',
 'HTTP_HOST': 'input.mozilla.com',
 'HTTP_KEEP_ALIVE': '115',
 'HTTP_USER_AGENT': 'Mozilla/5.0 (X11; Linux i686; rv:2.0b7) Gecko/20100101 Firefox/4.0b7',
 'HTTP_X_CLUSTER_CLIENT_IP': '68.103.197.41',
 'PATH_INFO': u'/en-US/search/',
 'PATH_TRANSLATED': '/data/www/django/input.mozilla.com/reporter/wsgi/reporter.wsgi/en-US/search/',
 'QUERY_STRING': 'product=firefox&version=4.0b7&locale=en-US&os=linux&page=0',
 'REMOTE_ADDR': '10.8.81.200',
 'REMOTE_PORT': '44131',
 'REQUEST_METHOD': 'GET',
 'REQUEST_URI': '/en-US/search/?product=firefox&version=4.0b7&locale=en-US&os=linux&page=0',
 'SCRIPT_FILENAME': '/data/www/django/input.mozilla.com/reporter/wsgi/reporter.wsgi',
 'SCRIPT_NAME': u'',
 'SERVER_ADDR': '10.8.81.20',
 'SERVER_ADMIN': '[e-mail]',
 'SERVER_NAME': 'input.mozilla.com',
 'SERVER_PORT': '80',
 'SERVER_PROTOCOL': 'HTTP/1.1',
 'SERVER_SIGNATURE': '',
 'SERVER_SOFTWARE': 'Apache',
 'mod_wsgi.application_group': 'input.mozilla.com|',
 'mod_wsgi.callable_object': 'application',
 'mod_wsgi.handler_script': '',
 'mod_wsgi.input_chunked': '0',
 'mod_wsgi.listener_host': '',
 'mod_wsgi.listener_port': '80',
 'mod_wsgi.process_group': 'input',
 'mod_wsgi.request_handler': 'wsgi-script',
 'mod_wsgi.script_reloading': '1',
 'mod_wsgi.version': (3, 3),
 'wsgi.errors': <mod_wsgi.Log object at 0x2adfad7e5130>,
 'wsgi.file_wrapper': <built-in method file_wrapper of mod_wsgi.Adapter object at 0x2adfaf05bc60>,
 'wsgi.input': <mod_wsgi.Input object at 0x2adfad7e59b0>,
 'wsgi.loaded': datetime.datetime(2010, 12, 19, 12, 47, 4, 108549),
 'wsgi.multiprocess': True,
 'wsgi.multithread': False,
 'wsgi.run_once': False,
 'wsgi.url_scheme': 'http',
 'wsgi.version': (1, 1)}>

Comment 1

[Fred Wenzel [:wenzel]]

I can reproduce that on both prod and stage. Will fix tomorrow.

Comment 2

[Fred Wenzel [:wenzel]]

Fix and test: http://github.com/fwenzel/reporter/commit/089c81a

Comment 3

[Fred Wenzel [:wenzel]]

QA: You can verify this by searching for something, changing the page, and subsequently changing the URL so that it contains page=0 or any page <= 0. If this does not throw a server error, this is fixed.

Comment 4

[Rebecca Billings [:rbillings]]

Verified no tracebacks for page tests such as: http://input.stage.mozilla.com/en-US/search/?product=mobile&version=4.0b2&date_start=&date_end=&q=fonts&page=0