Closed
Bug 620304
Opened 15 years ago
Closed 15 years ago
crash [@ nsTypedSelection::GetIndicesForInterval] if !aStartIndex/!aEndIndex
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla2.0b9
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, crash)
Crash Data
Attachments
(1 file)
|
855 bytes,
patch
|
jst
:
review+
jst
:
approval2.0+
|
Details | Diff | Splinter Review |
4062 nsTypedSelection::GetIndicesForInterval(nsINode* aBeginNode,
4066 PRInt32 *aStartIndex,
4067 PRInt32 *aEndIndex)
4069 if (aStartIndex)
4070 *aStartIndex = -1;
4071 if (aEndIndex)
4072 *aEndIndex = -1;
4174 *aStartIndex = beginsAfterIndex;
4175 *aEndIndex = endsBeforeIndex;
the code also writes to aEndIndex in the middle of the function:
4105 *aEndIndex = endsBeforeIndex;
so it seems easier to unconditionally support writing
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498691 -
Flags: review?(jst)
Attachment #498691 -
Flags: approval2.0?
|
||
Updated•15 years ago
|
Attachment #498691 -
Flags: review?(jst)
Attachment #498691 -
Flags: review+
Attachment #498691 -
Flags: approval2.0?
Attachment #498691 -
Flags: approval2.0+
Keywords: checkin-needed
|
||
Comment 2•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
|
||
Updated•14 years ago
|
Crash Signature: [@ nsTypedSelection::GetIndicesForInterval]
|
||
Updated•7 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•