Closed Bug 620304 Opened 9 years ago Closed 9 years ago

crash [@ nsTypedSelection::GetIndicesForInterval] if !aStartIndex/!aEndIndex

Categories

(Core :: Layout, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla2.0b9

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, crash)

Crash Data

Attachments

(1 file)

4062 nsTypedSelection::GetIndicesForInterval(nsINode* aBeginNode,
4066                                         PRInt32 *aStartIndex,
4067                                         PRInt32 *aEndIndex)

4069   if (aStartIndex)
4070     *aStartIndex = -1;
4071   if (aEndIndex)
4072     *aEndIndex = -1;

4174   *aStartIndex = beginsAfterIndex;
4175   *aEndIndex = endsBeforeIndex;
the code also writes to aEndIndex in the middle of the function:
4105   *aEndIndex = endsBeforeIndex;

so it seems easier to unconditionally support writing
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498691 - Flags: review?(jst)
Attachment #498691 - Flags: approval2.0?
Attachment #498691 - Flags: review?(jst)
Attachment #498691 - Flags: review+
Attachment #498691 - Flags: approval2.0?
Attachment #498691 - Flags: approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/93a4e6520352
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
Crash Signature: [@ nsTypedSelection::GetIndicesForInterval]
You need to log in before you can comment on or make changes to this bug.