620306 - crash [@ nsFtpState::Init] for oom from BeginWriting()

Status: RESOLVED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[timeless]

1675 nsFtpState::Init(nsFtpChannel *channel)

1700     char *fwdPtr = path.BeginWriting();

this noble oom check:
1701     if (fwdPtr && (*fwdPtr == '/'))
1702         fwdPtr++;

is immediately defeated:
1703     if (*fwdPtr != '\0') {

Comment 1

[timeless]

Attachment: proposal

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 498695 [details] [diff] [review]
proposal

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 498695 [details] [diff] [review]
proposal

Review of attachment 498695 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 4

[Jason Duell]

Ready to land?

Comment 5

[Ed Morley [:emorley]]

Sent to try:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=626e32292fdc

Assuming all green, will push to inbound after :-)

Comment 6

[Ed Morley [:emorley]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/13010f8b9fe1

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/13010f8b9fe1