Note: There are a few cases of duplicates in user autocompletion which are being worked on.

crash [@ nsFtpState::Init] for oom from BeginWriting()

RESOLVED FIXED in mozilla9

Status

()

Core
Networking: FTP
--
critical
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({coverity, crash})

Trunk
mozilla9
coverity, crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
1675 nsFtpState::Init(nsFtpChannel *channel)

1700     char *fwdPtr = path.BeginWriting();

this noble oom check:
1701     if (fwdPtr && (*fwdPtr == '/'))
1702         fwdPtr++;

is immediately defeated:
1703     if (*fwdPtr != '\0') {
(Assignee)

Comment 1

7 years ago
Created attachment 498695 [details] [diff] [review]
proposal
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498695 - Flags: review?(cbiesinger)
Attachment #498695 - Flags: approval2.0?
Comment on attachment 498695 [details] [diff] [review]
proposal

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Attachment #498695 - Flags: approval2.0? → approval2.0-
Crash Signature: [@ nsFtpState::Init]
Comment on attachment 498695 [details] [diff] [review]
proposal

Review of attachment 498695 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #498695 - Flags: review?(cbiesinger) → review+
Ready to land?
Keywords: checkin-needed

Comment 5

6 years ago
Sent to try:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=626e32292fdc

Assuming all green, will push to inbound after :-)

Comment 6

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/13010f8b9fe1
Keywords: checkin-needed
Whiteboard: [inbound]

Updated

6 years ago
Target Milestone: --- → mozilla9
http://hg.mozilla.org/mozilla-central/rev/13010f8b9fe1
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.