Last Comment Bug 620306 - crash [@ nsFtpState::Init] for oom from BeginWriting()
: crash [@ nsFtpState::Init] for oom from BeginWriting()
Status: RESOLVED FIXED
: coverity, crash
Product: Core
Classification: Components
Component: Networking: FTP (show other bugs)
: Trunk
: All All
: -- critical (vote)
: mozilla9
Assigned To: timeless
:
: Patrick McManus [:mcmanus]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-19 17:14 PST by timeless
Modified: 2011-08-21 11:28 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
proposal (760 bytes, patch)
2010-12-20 01:32 PST, timeless
cbiesinger: review+
jst: approval2.0-
Details | Diff | Splinter Review

Description timeless 2010-12-19 17:14:55 PST
1675 nsFtpState::Init(nsFtpChannel *channel)

1700     char *fwdPtr = path.BeginWriting();

this noble oom check:
1701     if (fwdPtr && (*fwdPtr == '/'))
1702         fwdPtr++;

is immediately defeated:
1703     if (*fwdPtr != '\0') {
Comment 1 timeless 2010-12-20 01:32:38 PST
Created attachment 498695 [details] [diff] [review]
proposal
Comment 2 Johnny Stenback (:jst, jst@mozilla.com) 2011-02-15 12:51:30 PST
Comment on attachment 498695 [details] [diff] [review]
proposal

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Comment 3 Christian :Biesinger (don't email me, ping me on IRC) 2011-07-22 15:47:24 PDT
Comment on attachment 498695 [details] [diff] [review]
proposal

Review of attachment 498695 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 4 Jason Duell [:jduell] (needinfo me) 2011-08-19 20:52:13 PDT
Ready to land?
Comment 5 Ed Morley [:emorley] 2011-08-20 15:58:41 PDT
Sent to try:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=626e32292fdc

Assuming all green, will push to inbound after :-)
Comment 7 :Ms2ger (⌚ UTC+1/+2) 2011-08-21 11:28:25 PDT
http://hg.mozilla.org/mozilla-central/rev/13010f8b9fe1

Note You need to log in before you can comment on or make changes to this bug.