620351 - The earthquakes in Nine Point Five don't work properly if methodjit is enabled

Status: RESOLVED DUPLICATE of bug 612334

(Core :: JavaScript Engine, defect)

Description

[JK]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7) Gecko/20100101 Firefox/4.0b7
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20101219 Firefox/4.0b9pre

The earthquakes Nine Point Five don't work properly in Minefield, but works in Chrome.

Error: invalid arguments
Source File: http://www.ninepointfive.org/static/nine5.js
Line: 9

Reproducible: Always

Comment 1

[JK]

You'll need to click the little "tour" button, which is the fourth button above "9,5".

Comment 2

[JK]

Attachment: On Minefield

NaN undefined

Comment 3

[JK]

Attachment: On Chrome (1)

Comment 4

[JK]

Attachment: On Chrome (2)

Comment 5

[Csaba Kozák [:WonderCsabo]]

Confirm.

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

The line of code mentioned in comment 0 is:

  var fa = new Float32Array(data.length / 6 * 8);

I guess that the problem is that length/6*8 is not integer and that this demo is relying on it to be rounded ?

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

That part was about us generating a warning when data.length == 0, we shouldn't, fixing this on our side.

The visual glitch seems to be unrelated, and a more far-reaching issue: from email conversation with the authors of this app: "The significant events (the sidebar with the list of top earthquakes) isn't working at all under Firefox.  Seems like the data isn't getting in, so there must be something happening in the JavaScript.  It works fine on SFX and v8."

Comment 8

[Benoit Jacob [:bjacob] (mostly away)]

So, the warning was not caused by length==0, it was caused by the length being non-integer, since division produces a floating-point value.

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

Please ignore comment 8 --- the warning is really related to length==0.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Is data.length not divisible by 3 here?  Or are we just seeing bug 612334?

Comment 11

[Alice0775 White]

It works if I set javascript.options.methodjit.content to false.

Comment 12

[Alice0775 White]

And I confirmed that attachment 499220 [details] [diff] [review] of Bug 612334 fixed this in local build.