Closed Bug 620359 Opened 9 years ago Closed 9 years ago
Wrongly ordered members in ns
Audio Stream Remote::ns Audio Stream Remote() constructor
Bug 612798 reordered the member declarations, but didn't update the constructor.
Attachment #498719 - Flags: review?(kinetik)
I'd rather not have the commas at the start of each line. Otherwise it looks fine, thanks.
AIUI, that's the canonical style, though.
Not in any code that I've worked on, not in the coding style doc on MDC, and certainly not in content/media.
(Yeah, that style varies across components & files.) I just ran into this warning myself & I was going to file a bug, but then I found this existing bug, lying semi-dormant. :) Ms2ger, would you mind tweaking the patch per Comment 1 so this warning can go away?
Whiteboard: [build_warning] → [build_warning][needs approval]
Attachment #505369 - Flags: approval2.0? → approval2.0+
Whiteboard: [build_warning][needs approval] → [build_warning]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
Can someone please confirm if this is fixed?
Confirmed fixed. (No GCC build warning if I touch nsAudioStream.cpp and rebuild.)
You need to log in before you can comment on or make changes to this bug.