Closed
Bug 620359
Opened 15 years ago
Closed 15 years ago
Wrongly ordered members in nsAudioStreamRemote::nsAudioStreamRemote() constructor
Categories
(Core :: Audio/Video, defect)
Tracking
()
VERIFIED
FIXED
mozilla2.0b12
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file, 2 obsolete files)
|
1.92 KB,
patch
|
Details | Diff | Splinter Review |
Bug 612798 reordered the member declarations, but didn't update the constructor.
Flags: in-testsuite-
Attachment #498719 -
Flags: review?(kinetik)
|
||
Comment 1•15 years ago
|
||
I'd rather not have the commas at the start of each line. Otherwise it looks fine, thanks.
|
Assignee | |
Comment 2•15 years ago
|
||
AIUI, that's the canonical style, though.
|
|
||
Comment 3•15 years ago
|
||
Not in any code that I've worked on, not in the coding style doc on MDC, and certainly not in content/media.
|
||
Comment 4•15 years ago
|
||
(Yeah, that style varies across components & files.)
I just ran into this warning myself & I was going to file a bug, but then I found this existing bug, lying semi-dormant. :) Ms2ger, would you mind tweaking the patch per Comment 1 so this warning can go away?
|
|
Assignee | |
Updated•15 years ago
|
Attachment #498719 -
Attachment is obsolete: true
Attachment #498719 -
Flags: review?(kinetik)
|
|
Assignee | |
Comment 5•15 years ago
|
||
Attachment #505369 -
Flags: approval2.0?
|
|
||
Updated•15 years ago
|
Attachment #505369 -
Flags: review+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [build_warning] → [build_warning][needs approval]
Attachment #505369 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [build_warning][needs approval] → [build_warning]
|
|
Assignee | |
Comment 6•15 years ago
|
||
Attachment #505369 -
Attachment is obsolete: true
|
|
||
Comment 7•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
|
|
||
Comment 9•15 years ago
|
||
Confirmed fixed. (No GCC build warning if I touch nsAudioStream.cpp and rebuild.)
|
|
||
Updated•15 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•