Fix unused variable warning in StatementCache::FinalizeCachedStatements

RESOLVED FIXED in mozilla2.0b9

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla2.0b9
x86
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

8 years ago
Created attachment 498720 [details] [diff] [review]
Patch v1

Since bug 599969, rv has been unused in opt builds.
Flags: in-testsuite-
Attachment #498720 - Flags: review?(sdwilsh)
Comment on attachment 498720 [details] [diff] [review]
Patch v1

>-    nsresult rv = aStatement->Finalize();
>+#ifdef DEBUG
>+    nsresult rv =
>+#endif
>+    aStatement->Finalize();
>     NS_WARN_IF_FALSE(NS_SUCCEEDED(rv), "Finalizing statement failed!");
It's actually silly to warn since storage code will also warn.  Just change the line to :
(void)aStatement->Finalize();

r=sdwilsh with that change.
Attachment #498720 - Flags: review?(sdwilsh) → review+
(Assignee)

Comment 2

8 years ago
Created attachment 498743 [details] [diff] [review]
Patch v2

Thanks.
Attachment #498720 - Attachment is obsolete: true
Attachment #498743 - Flags: approval2.0?
Attachment #498743 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 3

8 years ago
Created attachment 498775 [details] [diff] [review]
Patch for checkin
Attachment #498743 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/c544c99fad5a
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in before you can comment on or make changes to this bug.