Closed Bug 620360 Opened 10 years ago Closed 10 years ago
Fix unused variable warning in Statement
Cache::Finalize Cached Statements
Since bug 599969, rv has been unused in opt builds.
Attachment #498720 - Flags: review?(sdwilsh)
Comment on attachment 498720 [details] [diff] [review] Patch v1 >- nsresult rv = aStatement->Finalize(); >+#ifdef DEBUG >+ nsresult rv = >+#endif >+ aStatement->Finalize(); > NS_WARN_IF_FALSE(NS_SUCCEEDED(rv), "Finalizing statement failed!"); It's actually silly to warn since storage code will also warn. Just change the line to : (void)aStatement->Finalize(); r=sdwilsh with that change.
Attachment #498720 - Flags: review?(sdwilsh) → review+
Attachment #498743 - Flags: approval2.0? → approval2.0+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in before you can comment on or make changes to this bug.