Closed
Bug 620360
Opened 14 years ago
Closed 14 years ago
Fix unused variable warning in StatementCache::FinalizeCachedStatements
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b9
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file, 2 obsolete files)
|
913 bytes,
patch
|
Details | Diff | Splinter Review |
Since bug 599969, rv has been unused in opt builds.
Flags: in-testsuite-
Attachment #498720 -
Flags: review?(sdwilsh)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 498720 [details] [diff] [review]
Patch v1
>- nsresult rv = aStatement->Finalize();
>+#ifdef DEBUG
>+ nsresult rv =
>+#endif
>+ aStatement->Finalize();
> NS_WARN_IF_FALSE(NS_SUCCEEDED(rv), "Finalizing statement failed!");
It's actually silly to warn since storage code will also warn. Just change the line to :
(void)aStatement->Finalize();
r=sdwilsh with that change.
Attachment #498720 -
Flags: review?(sdwilsh) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Thanks.
Attachment #498720 -
Attachment is obsolete: true
Attachment #498743 -
Flags: approval2.0?
|
|
||
Updated•14 years ago
|
Attachment #498743 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #498743 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in
before you can comment on or make changes to this bug.
Description
•