Closed Bug 620362 Opened 9 years ago Closed 9 years ago

Uninitialized variable warning in nsNavHistory::InternalAddNewPage

Categories

(Toolkit :: Places, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b11

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

Attached patch Patch v1Splinter Review
Bug 556631 caused an uninitialized variable warning about pageId.
Flags: in-testsuite-
Attachment #498722 - Flags: review?(mak77)
Comment on attachment 498722 [details] [diff] [review]
Patch v1

is this a scoping issue? we assign it in the subscope before using it in the method, I don't see uses of it before the assignment. Btw the patch looks ok.
Attachment #498722 - Flags: review?(mak77) → review+
Comment on attachment 498722 [details] [diff] [review]
Patch v1

Yeah, my compiler doesn't seem to like nested scopes much.
Attachment #498722 - Flags: approval2.0?
Whiteboard: [build_warning] → [build_warning][needs approval]
Attachment #498722 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
Whiteboard: [build_warning][needs approval] → [build_warning]
http://hg.mozilla.org/mozilla-central/rev/7252a4d4e943
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b11
You need to log in before you can comment on or make changes to this bug.