Wrongly ordered members in History::History() constructor

RESOLVED FIXED in mozilla2.0b9

Status

()

Toolkit
Places
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla2.0b9
x86
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 498729 [details] [diff] [review]
Patch v1

Bug 599969 added syncStatements before mShuttingDown in the header, but after in the constructor.
Flags: in-testsuite-
Attachment #498729 - Flags: review?(sdwilsh)
the removal of mozilla:: from the namespacing is correct, but since all the rest of the file uses mozilla::dom and mozilla::services, I'd not change it just in one place. Probably not worth it changing in all places too, imo.
Comment on attachment 498729 [details] [diff] [review]
Patch v1

r=sdwilsh
Attachment #498729 - Flags: review?(sdwilsh)
Attachment #498729 - Flags: review+
Attachment #498729 - Flags: approval2.0+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

7 years ago
Created attachment 498747 [details] [diff] [review]
Patch for checkin
Attachment #498729 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/438d6a2f3a9c
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in before you can comment on or make changes to this bug.