Closed Bug 620375 Opened 12 years ago Closed 12 years ago

Wrongly ordered members in History::History() constructor

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b9

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Whiteboard: [build_warning])

Attachments

(1 file, 1 obsolete file)

Patch for checkin
1.03 KB, patch
Details | Diff | Splinter Review
Attached patch Patch v1 (obsolete) — — Splinter Review 
Bug 599969 added syncStatements before mShuttingDown in the header, but after in the constructor.
Flags: in-testsuite-
Attachment #498729 - Flags: review?(sdwilsh)
the removal of mozilla:: from the namespacing is correct, but since all the rest of the file uses mozilla::dom and mozilla::services, I'd not change it just in one place. Probably not worth it changing in all places too, imo.
Comment on attachment 498729 [details] [diff] [review]
Patch v1

r=sdwilsh
Attachment #498729 - Flags: review?(sdwilsh)
Attachment #498729 - Flags: review+
Attachment #498729 - Flags: approval2.0+
Keywords: checkin-needed

        Attachment #498729 -
        Attachment is obsolete: true

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/438d6a2f3a9c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9

          You need to log in
          before you can comment on or make changes to this bug.