add fall through comment to txXPCOMExtensionFunctionCall::GetParamType

RESOLVED FIXED in mozilla5

Status

()

Core
XSLT
--
enhancement
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({coverity})

Trunk
mozilla5
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
293 txXPCOMExtensionFunctionCall::GetParamType(const nsXPTParamInfo &aParam,
294                                            nsIInterfaceInfo *aInfo)
295 {
296     PRUint8 tag = aParam.GetType().TagPart();
297     switch (tag) {
305         case nsXPTType::T_INTERFACE_IS:
306         {
315             if (iid.Equals(NS_GET_IID(txIXPathObject))) {
316                 return eOBJECT;
317             }
318         }

a fall through comment here would help tools/readers

319         default:
320         {
321             // XXX Error!
322             return eUNKNOWN;
323         }
(Assignee)

Comment 1

7 years ago
Created attachment 498894 [details] [diff] [review]
add fallthrough comment
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498894 - Flags: review?(peterv)
Attachment #498894 - Flags: approval2.0?
Comment on attachment 498894 [details] [diff] [review]
add fallthrough comment

Pfff, what a waste of time.
Attachment #498894 - Flags: review?(peterv) → review+
Comment on attachment 498894 [details] [diff] [review]
add fallthrough comment

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Attachment #498894 - Flags: approval2.0? → approval2.0-

Comment 4

7 years ago
http://hg.mozilla.org/mozilla-central/rev/3f5dec6175eb
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.