620411 - nsUserInfo::GetDomain performs a useless null check on an array in nsUserInfoUnix.cpp

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement)

Description

[timeless]

134 nsUserInfo::GetDomain(char * *aDomain)
135 {
138     struct utsname buf;
160         if (buf.nodename && buf.nodename[0]) {

http://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/utsname.h.html
The <sys/utsname.h> header shall define the structure utsname which shall include at least the following members:

char  sysname[]  Name of this implementation of the operating system. 
char  nodename[] Name of this node within the communications 
                 network to which this node is attached, if any. 
char  release[]  Current release level of this implementation. 
char  version[]  Current version level of this release. 
char  machine[]  Name of the hardware type on which the system is running.

Comment 1

[timeless]

Attachment: patch

Comment 2

[Alex Xu]

clang now warns on this.

Comment 3

[Alex Xu]

which means that warnings-as-errors builds on clang 3.5 fail.

patch compiles successfully here (at least insofar as passing that file; other bugs stop the build)

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Can this be landed? It is hassle to keep applying this patch locally to build and then undo the change before committing changes for other bugs.

Comment 5

[Daniel Holbert [:dholbert]]

timeless said in IRC he can't remember why he removed checkin-needed (after comment 1), and that he's cool with me landing this on his behalf.

Comment 6

[Daniel Holbert [:dholbert]]

Tweaked commit message to describe-the-change (instead of the problem) & landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/373b1a2edd6a

(Hooray, one fewer local patch I have to apply locally to build w/ newish clang :))

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/373b1a2edd6a