Closed Bug 620421 Opened 9 years ago Closed 9 years ago

remove useless check of mTokenPos from nsSVGTransformListParser::GetTransformToken

Categories

(Core :: SVG, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b12

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(1 file)

109 nsSVGTransformListParser::GetTransformToken(nsIAtom** aKeyAtom,
110                                             PRBool aAdvancePos)
111 {
deref mTokenPos:
112   if (mTokenType != OTHER || *mTokenPos == '\0') {

120   if (delimiterStart != 0) {

hopefully useless check of mTokenPos:
126     if (mTokenPos != 0 && (len = nsCRT::strlen(mTokenPos)) > 0) {
jwatt may well be rewriting all of this in bug 602759
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498918 - Flags: review?(jwatt)
Attachment #498918 - Flags: approval2.0?
Comment on attachment 498918 [details] [diff] [review]
patch

I'm not really sure drivers want to have harmless stuff like this put on their radar at this stage, but I guess you can have the r=jwatt.
Attachment #498918 - Flags: review?(jwatt) → review+
Attachment #498918 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/7ec853227cb3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
You need to log in before you can comment on or make changes to this bug.