Note: There are a few cases of duplicates in user autocompletion which are being worked on.

jsemit.cpp compile failure when #undef JS_HAS_SHARP_VARS

RESOLVED FIXED in mozilla11

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Andrew Paprocki, Assigned: Andrew Paprocki)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 498776 [details] [diff] [review]
Define sharpnum always

The definition of the EmitNewInit() static function in jsemit.cpp always has a "sharpnum" argument. This function is called 3 times within the file outside of JS_HAS_SHARP_VARS checks passing the "sharpnum" variable. This variable is only defined when JS_HAS_SHARP_VARS is defined, thus breaking the build.

The attached patch simply always defines the variable since it is always passed to EmitNewInit(). I assume this is preferred over putting the definition of EmitNewInit() as well as all the callers inside #ifdefs.
(Assignee)

Updated

7 years ago
Attachment #498776 - Flags: review?(mrbkap)

Updated

7 years ago
Attachment #498776 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 1

6 years ago
Created attachment 569267 [details] [diff] [review]
Define sharpnum always

Revisiting old bugs, rebased patch to mozilla-inbound.
Attachment #498776 - Attachment is obsolete: true
Attachment #569267 - Flags: review?(mrbkap)

Updated

6 years ago
Attachment #569267 - Flags: review?(mrbkap) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Assignee: general → andrew

Comment 2

6 years ago
{
applying thg-import-agrin7.patch
unable to find 'js/src/frontend/BytecodeGenerator.cpp' for patching
1 out of 1 hunks FAILED -- saving rejects to file js/src/frontend/BytecodeGenerator.cpp.rej
}
Keywords: checkin-needed
(Assignee)

Comment 3

6 years ago
Ed, this checkin failed? Were you applying the patch to mozilla-inbound?

Comment 4

6 years ago
Yeah sorry meant to put was applying to inbound.
Thanks :-)
(Assignee)

Comment 5

6 years ago
Created attachment 576064 [details] [diff] [review]
Always define sharpnum

Updated patch to apply clean to m-i.
Attachment #569267 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/215ba0c3d5b7
Keywords: checkin-needed
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/215ba0c3d5b7
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.