620510 - jsd_obj.c miscompiles ("warning: assignment from incompatible pointer type")

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

From bug 612150 comment 8 by Andrew Paprocki:

In the 2.0b8 branch, I see a broken jsd_obj.c with this change..

    const char* ctorName;
...
                ctorName = jsd_GetScriptFunctionName(jsdc, jsdscript);

This returns a JSString* now. Getting:

jsd_obj.c: In function 'jsd_Constructing':
jsd_obj.c:160: error: assignment from incompatible pointer type

Comment 1

[Igor Bukanov]

Nominating for 2.0: the bug is a regression in a non-default build.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

** PRODUCT DRIVERS PLEASE NOTE **

This bug is one of 19 being moved from blocking2.0:betaN+ to blocking2.0:- as we reached the endgame of Firefox 4. The rationale for the move is:

 - the bug had been identified as a "soft" blocker which could be fixed in some follow up release
 - the bug had been identified as one requiring beta coverage, thus is not appropriate for a ".x" stability & security release

The owner of the bug may wish to renominate for .x consideration.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

(er updating flag to "-" as per previous comment!)

Comment 4

[Andrew Paprocki]

Code has since been updated to fix this issue under another ticket.