620522 - Make default add-ons snippet identifiable by AMO

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Justin Scott [:fligtar]]

chrome://browser/content/aboutHome.js has a default add-ons snippet pointing to https://addons.mozilla.org/firefox/?browse=featured

I'd like this to be an identifiable URL so that we can measure its usage and do custom promotions if needed later on.

Can we change it to: https://addons.mozilla.org/firefox/?src=snippet

Thanks

Comment 1

[Dave Townsend [:mossop]]

Marco, where does this bug belong?

Comment 2

[Justin Scott [:fligtar]]

This bug still exists in the new about:home and I'm still not sure if this bug is in the right place.

Comment 3

[Marco Bonardo [:mak]]

sigh, I missed this bug in the middle of bugmail :(

(In reply to comment #1)
> Marco, where does this bug belong?

Firefox General is the right components for about:home, so far... probably we should use a whiteboard special search for all related bugs though :(

yes we can change it, if you want to patch it by yourself and submit a patch it should be pretty trivial (just change the url in aboutHome.js).
Notice that once remote snippets service will be alive (bug 592431, you probably want to give there the right url too), default snippets won't show up much (just in case we don't have the remote ones)

Comment 4

[Justin Scott [:fligtar]]

I'm not a developer and have never checked out the Firefox code, so me submitting a patch is not ideal :)

Comment 5

[Marco Bonardo [:mak]]

ok, I can do that, is src=snippet a query string that you already discussed with webdev, statistics?
So, is it just matter of changing the url or we need to ping someone else to hook it up the management in amo?

Comment 6

[Justin Scott [:fligtar]]

It's just the URL change, we don't need any other setup. I'm on the AMO team.

Comment 7

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Asking review to Dave to avoid overloading Gavin (plus add-ons related change)
Requires approval to land, I'm already setting the flag because the patch is  trivial.

Comment 8

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/731505d88422

Comment 9

[Teodosia Pop]

Verified using Mozilla/5.0 (Windows NT 6.1; rv:2.0b12) Gecko/20100101 Firefox/4.0b12.