[Classic] Missing Treelines in bookmarks (sidebar and manager)

RESOLVED FIXED

Status

SeaMonkey
UI Design
--
critical
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Karsten Düsterloh, Assigned: Karsten Düsterloh)

Tracking

({regression})

Trunk
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

3.35 KB, patch
Karsten Düsterloh
: review+
Karsten Düsterloh
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Yet again... :-(

+++ This bug was initially created as a regression clone of Bug #438793 +++

Trees with at least 2 sub levels should have tree lines, as was done in bug 438793. This regressed for bookmarks, probably when porting from toolkit.

Comment 1

7 years ago
That would have been KaiRo's fault then ;-)
(Assignee)

Comment 2

7 years ago
Created attachment 499016 [details] [diff] [review]
add missing treelines attribute

I also took the liberty to fix the stray multi-attribute line.
Assignee: nobody → mnyromyr
Status: NEW → ASSIGNED
Attachment #499016 - Flags: superreview?(neil)
Attachment #499016 - Flags: review?(neil)

Comment 3

7 years ago
Comment on attachment 499016 [details] [diff] [review]
add missing treelines attribute

I noticed that editBookmarkOverlay.xul (used for editing a bookmark either for the current page via the star button), when you select the full folder chooser, already has treelines enabled. But you seem to have overlooked the bookmarks manager's Edit - Move bookmark dialog for some reason.
Attachment #499016 - Flags: superreview?(neil)
Attachment #499016 - Flags: superreview+
Attachment #499016 - Flags: review?(neil)
Attachment #499016 - Flags: review+
(Assignee)

Comment 4

7 years ago
Created attachment 499126 [details] [diff] [review]
also fix moveBookmarks.xul

(In reply to comment #3)
> But you seem to have overlooked the bookmarks manager's Edit - Move bookmark
> dialog for some reason.

Man, that dialog is so 90's UI... :-/

Taking over r/sr.

Landed as <http://hg.mozilla.org/comm-central/rev/d9239f961031>.
Attachment #499016 - Attachment is obsolete: true
Attachment #499126 - Flags: superreview+
Attachment #499126 - Flags: review+
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.