Closed
Bug 620531
Opened 14 years ago
Closed 14 years ago
[Classic] Missing Treelines in bookmarks (sidebar and manager)
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mnyromyr, Assigned: mnyromyr)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
3.35 KB,
patch
|
mnyromyr
:
review+
mnyromyr
:
superreview+
|
Details | Diff | Splinter Review |
Yet again... :-(
+++ This bug was initially created as a regression clone of Bug #438793 +++
Trees with at least 2 sub levels should have tree lines, as was done in bug 438793. This regressed for bookmarks, probably when porting from toolkit.
|
||
Comment 1•14 years ago
|
||
That would have been KaiRo's fault then ;-)
|
Assignee | |
Comment 2•14 years ago
|
||
I also took the liberty to fix the stray multi-attribute line.
Assignee: nobody → mnyromyr
Status: NEW → ASSIGNED
Attachment #499016 -
Flags: superreview?(neil)
Attachment #499016 -
Flags: review?(neil)
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 499016 [details] [diff] [review]
add missing treelines attribute
I noticed that editBookmarkOverlay.xul (used for editing a bookmark either for the current page via the star button), when you select the full folder chooser, already has treelines enabled. But you seem to have overlooked the bookmarks manager's Edit - Move bookmark dialog for some reason.
Attachment #499016 -
Flags: superreview?(neil)
Attachment #499016 -
Flags: superreview+
Attachment #499016 -
Flags: review?(neil)
Attachment #499016 -
Flags: review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to comment #3)
> But you seem to have overlooked the bookmarks manager's Edit - Move bookmark
> dialog for some reason.
Man, that dialog is so 90's UI... :-/
Taking over r/sr.
Landed as <http://hg.mozilla.org/comm-central/rev/d9239f961031>.
Attachment #499016 -
Attachment is obsolete: true
Attachment #499126 -
Flags: superreview+
Attachment #499126 -
Flags: review+
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•