620553 - cfx --help should mention default value of --templatedir flag

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: Documentation, defect, P3)

Description

[Myk Melez [:myk] [@mykmelez]]

cfx --help should mention the default value of the --templatedir flag, so folks who want to copy it and use it as the basis of their custom template directory know where to look.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Myk, is this still wanted? Testing locally, cfx --help still doesn't show the default value for templatedir. But maybe we're too close to switching over to a JS version for this to matter... :)

Comment 2

[Myk Melez [:myk] [@mykmelez]]

A JS version is still far away, but in any case, it will still have the `cfx` command-line tool and a template directory, so this is still wanted.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(Pushing all open bugs to the --- milestone for the new triage system)

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Add the default

Something like this?

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 570370 [details] [diff] [review]
Add the default

>diff --git a/python-lib/cuddlefish/__init__.py b/python-lib/cuddlefish/__init__.py
>index 15a78d1..1507331 100644
>--- a/python-lib/cuddlefish/__init__.py
>+++ b/python-lib/cuddlefish/__init__.py
>@@ -106,7 +106,7 @@ parser_groups = (
>         (("", "--templatedir",), dict(dest="templatedir",
>                                       help="XULRunner app/ext. template",
>                                       metavar=None,
>-                                      default=None,
>+                                      default="python-lib/cuddlefish/app-extension/",
>                                       cmds=['run', 'xpi'])),
>         (("", "--package-path",), dict(dest="packagepath", action="append",
>                                        help="extra directories for package search",

This doesn't cause cfx --help to mention the default value.  And it breaks cfx run and cfx xpi, which apply this relative path to the current working directory.

This information should be added to the help text.

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

Can we wontfix this because of bug 915376 ?

Comment 7

[Dave Townsend [:mossop]]

I agree, as a rule though I tend to keep bugs open until the thing that obsoletes them has landed.

Comment 8

[Erik Vold [:erikvold] (please needinfo? me)]

Sorry we won't be releasing any new versions of cfx, jpm is the replacement https://www.npmjs.com/package/jpm