620584 - Hardcode app id to org.mozilla.firefox instead of org.mozilla.@MOZ_APP_NAME@

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Wu [:mwu]]

Attachment: Hack

Patch attached just in case we need to do this. Going to write a cleaner patch to follow up, but this one works in case we need it ASAP.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

why would we want this?

Comment 2

[Michael Wu [:mwu]]

Attachment: Add ANDROID_PACKAGE_NAME

This allows apps to override the entire package name instead of just the end of org.mozilla. It defaults to org.mozilla.MOZ_APP_NAME but can be overwritten in the conf vars.

Comment 3

[Michael Wu [:mwu]]

Attachment: Use org.mozilla.firefox on branded builds

Comment 4

[Tony Chung [:tchung]]

can someone give some insight on how/what needs to be tested to adequately cover this fix?    for example, stuart briefly mentioned that a user that updates with this change will end up with 2 copies of firefox on their android device.  That doesnt sound like a good experience to me.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

I still don't understand why we want this

Comment 6

[Stuart Parmenter]

We need to get this for b3

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 498933 [details] [diff] [review]
Add ANDROID_PACKAGE_NAME

The build bits look fine to me.

Comment 8

[(not currently active) Ted Mielczarek]

For posterity's sake, if someone could answer blassey's question in-bug, that would be useful.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 498934 [details] [diff] [review]
Use org.mozilla.firefox on branded builds

We could put | ANDROID_PACKAGE_NAME=org.mozilla.fennec | in the nightly configure.sh just to be explicit, but it's not a big deal.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 498933 [details] [diff] [review]
Add ANDROID_PACKAGE_NAME

>-            String action = "org.mozilla.gecko.restart" + getAppName();
>+            String action = "org.mozilla.gecko.restart";
you need to change the restarter's action in the manifest. Have you tested this?

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 498933 [details] [diff] [review]
Add ANDROID_PACKAGE_NAME

please fix the restarter action and test the heck out of this

Comment 12

[Brian Crowder]

Comment 8 is a good one, why do we want this?  Can someone answer in the bug?

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

someone put our beta 2 build in the android market place with org.mozilla.fennec as its app id. For obvious reasons, the market place doesn't allow two apps with the same id. Its unclear at this time if google will fully remove the existing app from the market such that we can submit with org.mozilla.fennec.

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to trunk and relbranch:
http://hg.mozilla.org/mozilla-central/rev/74a67e4695d7
http://hg.mozilla.org/mozilla-central/rev/cdddfc399df3

and m-b:
http://hg.mozilla.org/mobile-browser/rev/a13c7b5a4225
http://hg.mozilla.org/mobile-browser/rev/e89ecb6ed8f8