Closed
Bug 620585
Opened 14 years ago
Closed 14 years ago
critical source code clarity issues in nsNavHistory.cpp
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: Gavin, Unassigned)
Details
(Whiteboard: wontfix?)
Attachments
(1 file)
|
29.05 KB,
patch
|
Details | Diff | Splinter Review |
There are some important errors in the nsNavHistory documentation that are harming code clarity and comment persistence.
|
Reporter | |
Comment 2•14 years ago
|
||
This is not complete, but for the sake of expediency I thought I'd get what I have up there. Shawn, please review this ASAP.
Attachment #498927 -
Flags: review?(sdwilsh)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 498927 [details] [diff] [review]
patch, part 1
I'm pretty hampered down with bug 606966 right now, so I suspect mak or dietrich can get to this before me.
Attachment #498927 -
Flags: review?(sdwilsh)
Attachment #498927 -
Flags: review?(mak77)
Attachment #498927 -
Flags: review?(dietrich)
|
||
Comment 4•14 years ago
|
||
I suggest wontfix because we fix comments only when touching related code, and because I like my blue bikeshed, thus I don't mind losing time in changing its color.
Whiteboard: wontfix?
|
|
||
Updated•14 years ago
|
Attachment #498927 -
Flags: review?(mak77)
|
|
||
Comment 5•14 years ago
|
||
dropping fake beta blocking and resolving, the different points of view on comments punctuation are probably not going to converge, but it's christmas, so it doesn't matter.
Status: NEW → RESOLVED
blocking2.0: beta9+ → ---
Closed: 14 years ago
Resolution: --- → WONTFIX
|
|
||
Updated•14 years ago
|
Attachment #498927 -
Flags: review?(dietrich)
You need to log in
before you can comment on or make changes to this bug.
Description
•