Closed Bug 620610 Opened 12 years ago Closed 12 years ago

Dump layer tree assignments when dumping display lists

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

Details

Attachments

(1 file, 1 obsolete file)

fix v2
3.52 KB, patch
tnikkel
: review+
Details | Diff | Splinter Review 
It's very helpful when debugging to be able to see which display items ended up in which display lists. This is easy to add.
Attached patch fix (obsolete) — — Splinter Review 

        Attachment #498957 -
        Flags: review?(tnikkel)

    
    

    
  
Comment on attachment 498957 [details] [diff] [review]
fix

Yay!

>-    fprintf(aOutput, "%s %p(%s) (%d,%d,%d,%d)(%d,%d,%d,%d)%s%s\n",
>+    fprintf(aOutput, "%s 0x%p(%s) (%d,%d,%d,%d)(%d,%d,%d,%d)%s%s",
>+        fprintf(aOutput, " layer=0x%p", layer);

I think this will print two copies of '0x' on Linux (at least in a little test program it did).

    
    

    
  
Hmm, it doesn't on Windows. I guess I'll just remove the 0xs.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix v2
        — 
          — Splinter Review
      

    


  

        Attachment #498957 -
        Attachment is obsolete: true

        Attachment #498975 -
        Flags: review?(tnikkel)

        Attachment #498957 -
        Flags: review?(tnikkel)

        Attachment #498975 -
        Flags: review?(tnikkel) → review+
Whiteboard: [needs landing]

    
    

    
  
Comment on attachment 498975 [details] [diff] [review]
fix v2

Changes only debug-only code

        Attachment #498975 -
        Flags: approval2.0?

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/c2325c5439c3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]

          You need to log in
          before you can comment on or make changes to this bug.