620610 - Dump layer tree assignments when dumping display lists

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's very helpful when debugging to be able to see which display items ended up in which display lists. This is easy to add.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Timothy Nikkel (:tnikkel)]

Comment on attachment 498957 [details] [diff] [review]
fix

Yay!

>-    fprintf(aOutput, "%s %p(%s) (%d,%d,%d,%d)(%d,%d,%d,%d)%s%s\n",
>+    fprintf(aOutput, "%s 0x%p(%s) (%d,%d,%d,%d)(%d,%d,%d,%d)%s%s",
>+        fprintf(aOutput, " layer=0x%p", layer);

I think this will print two copies of '0x' on Linux (at least in a little test program it did).

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Hmm, it doesn't on Windows. I guess I'll just remove the 0xs.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix v2

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 498975 [details] [diff] [review]
fix v2

Changes only debug-only code

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/c2325c5439c3