620880 - make jit tests use browser-configuration by default

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Paul Biggar]

The jit-tests currently run with --jitargs of 'j' by default. They should run the same thing we run in the browser, which I think is 'jmp'?

It would also be useful to add a mode to repeatedly test with each of '-j', '-m', etc, which I don't think we can do now.

Comment 1

[Nicholas Nethercote [inactive]]

It's called --jitflags and you can specify multiple modes, eg. --jitflags=j,mj.

'jmp' would be a decent default, 'j,m' would be even better, though twice as slow.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I think bz came up with a good set a while ago. I usually run with --jitflags=m,j,mj,mjp,mjd (d is debug mode). Given how fast these run, I see no reason to be conservative.

Comment 3

[Paul Biggar]

One option is to change the default to something fast running for us, like 'jmp', and change the 'make check' rule (which is run on tinderbox) to something more exhaustive, like m,j,mj,mjp,mjd.

Comment 4

[Paul Biggar]

Attachment: Add long flags for |make check| and just -mjp by default

This adds billm's long flags for make check, which is run by tinderbox (under the 'B' component). For humans, it sets the default to -mjp, which is more what we want to test than -j

Comment 5

[David Mandelin [:dmandelin]]

Comment on attachment 499677 [details] [diff] [review]
Add long flags for |make check| and just -mjp by default

It'd be nice to send an email to the internals list announcing this (or other changes in behavior of the test harness).

Comment 6

[Paul Biggar]

http://hg.mozilla.org/tracemonkey/rev/95b952a9d46f

I updated the help message too, I figured that didn't need review.

Sending mail now.

Comment 7

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/95b952a9d46f