Closed Bug 620898 Opened 14 years ago Closed 14 years ago

warning ... will be initialized after mWindowId in Image and imgRequest

Categories

(Core :: Graphics: ImageLib, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

modules/libpr0n/src/Image.h:
 In constructor ‘mozilla::imagelib::Image::Image(imgStatusTracker*)’:
151: warning: ‘mozilla::imagelib::Image::mError’ will be initialized after
143: warning:   ‘PRUint64 mozilla::imagelib::Image::mWindowId’
Image.cpp:44: warning:   when initialized here

modules/libpr0n/src/imgRequest.h:
 In constructor ‘imgRequest::imgRequest()’:
245: warning: ‘imgRequest::mIsInCache’ will be initialized after
237: warning:   ‘PRUint64 imgRequest::mWindowId’
imgRequest.cpp:189: warning:   when initialized here
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #499249 - Flags: review?(bzbarsky)
Attachment #499249 - Flags: approval2.0?
Argh, sorry about missing the warning. I did try to avoid such issues, but it looks like I still missed this one.
Comment on attachment 499249 [details] [diff] [review]
patch

I'm not a module owner for this code.
Attachment #499249 - Flags: review?(bzbarsky)
Attachment #499249 - Flags: review?(joe)
Attachment #499249 - Flags: review?(joe)
Attachment #499249 - Flags: review+
Attachment #499249 - Flags: approval2.0?
Attachment #499249 - Flags: approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/d9ec3e791cee
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [build_warning]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: