Closed Bug 620936 Opened 9 years ago Closed 9 years ago

Firefox 4 b6, 7 & 8 break dijit.form.FilteringSelect

Categories

(Core :: DOM: Editor, defect, major)

defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla2.0b10
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: rsolomon, Assigned: ehsan)

References

()

Details

(Keywords: regression, testcase, Whiteboard: [hardblocker](?))

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8) Gecko/20100101 Firefox/4.0b8
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8) Gecko/20100101 Firefox/4.0b8

In Firefox 4 since beta 6 the dijit.form.FilteringSelect is broken for dojo 1.2, 1.3 & 1.4. The select does not change the value and the javascript throws the following error: "Index or size is negative or greater than the allowed amount" code: "1""

This works fine in FF3.6 and 4.0 before beta 6.

Reproducible: Always

Steps to Reproduce:
1. Navigate to http://download.dojotoolkit.org/release-1.2.3/dojo-release-1.2.3/dijit/tests/form/_autoComplete.html?testWidget=dijit.form.FilteringSelect
2. Try to change the value in the first drop-down with US states.
Actual Results:  
The value stays the same and the javascript error above is thrown.

Expected Results:  
The value will change and there is no JS error.
First Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/886665dec3cb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100901 Firefox/4.0b6pre ID:20100902120235
Fails(1 of 2 fails):
http://hg.mozilla.org/mozilla-central/rev/f2f217290bd0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100901 Firefox/4.0b6pre ID:20100902130009
Pushlog(first regression):
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=886665dec3cb&tochange=f2f217290bd0

Working again window:
Fails:
http://hg.mozilla.org/mozilla-central/rev/983c38bb0f03
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100902 Firefox/4.0b6pre ID:20100902175204
Working again:
http://hg.mozilla.org/mozilla-central/rev/03f80b4e0318
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100902 Firefox/4.0b6pre ID:20100902180724
Pushlog(working again)
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=983c38bb0f03&tochange=03f80b4e0318

Second Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/68033b993ed7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100913 Firefox/4.0b6pre ID:20100913165011
Fails:
http://hg.mozilla.org/mozilla-central/rev/ccaffbc6a970
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100913 Firefox/4.0b6pre ID:20100913162558
Pushlog(second  regression):
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=68033b993ed7&tochange=ccaffbc6a970
Status: UNCONFIRMED → NEW
blocking2.0: --- → ?
Ever confirmed: true
Product: Firefox → Core
QA Contact: general → general
Target Milestone: --- → mozilla2.0
Version: unspecified → Trunk
Keywords: regression
Fails on Linux too.
Mozilla/5.0 (X11; Linux i686; rv:2.0b9pre) Gecko/20101222 Firefox/4.0b9pre ID:20101222030351
OS: Windows 7 → Linux
Hardware: x86_64 → All
In local build,
build from 055edd12d609 : fails
build from ccde84eb8c58 : fails
build from c3236786510b : fails
build from 1f29b4fb184c : works
build from 0f5a2dce1aa5 : works

candidate; c3236786510b	Ehsan Akhgari — Bug 240933 - Part 9: Simplify text control frame's DOM point to offset conversion code; r=roc a=dbaron


FYI, Selection works by keyboard. Selcection fails by mouse click.
Blocks: 240933
OS: Linux → All
blocking2.0: ? → betaN+
Component: General → Editor
QA Contact: general → editor
Flags: in-testsuite?
Minimized test case is in the URL field.  On 3.6, nothing is thrown.
Attached patch Patch (v1)Splinter Review
Attachment #501544 - Flags: review?(roc)
Whiteboard: [has patch][needs review roc]
Whiteboard: [has patch][needs review roc] → [has patch][needs review roc][hardblocker](?)
Whiteboard: [has patch][needs review roc][hardblocker](?) → [needs landing][hardblocker](?)
http://hg.mozilla.org/mozilla-central/rev/81cd70b6db84
Flags: in-testsuite? → in-testsuite+
Whiteboard: [needs landing][hardblocker](?) → [hardblocker](?)
Target Milestone: mozilla2.0 → mozilla2.0b10
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
I landed the following patch as a follow-up to switch to NS_MIN instead of PR_MIN.

http://hg.mozilla.org/mozilla-central/rev/a36ba194fd7c
You need to log in before you can comment on or make changes to this bug.